This is an archive of the discontinued LLVM Phabricator instance.

Differential D24773

[asan] Fix GlobalAddressDescription::Print()
ClosedPublic

Authored by filcab on Sep 20 2016, 11:03 AM.

Details

Reviewers
kcc
vitalybuka
eugenis
Commits
rG08c1eb9b6354: [asan] Fix GlobalAddressDescription::Print()
rCRT282012: [asan] Fix GlobalAddressDescription::Print()
rL282012: [asan] Fix GlobalAddressDescription::Print()
Summary

Check bug_type for nullptr before calling internal_strcmp

Diff Detail

Event Timeline

filcab updated this revision to Diff 71956.Sep 20 2016, 11:03 AM
filcab retitled this revision from to [asan] Fix GlobalAddressDescription::Print().
filcab updated this object.
filcab added reviewers: kcc, vitalybuka, eugenis.
filcab added a subscriber: llvm-commits.
Herald added a subscriber: kubamracek. · View Herald TranscriptSep 20 2016, 11:03 AM
filcab updated this revision to Diff 71958.Sep 20 2016, 11:25 AM

Pipe stderr too.

vitalybuka accepted this revision.Sep 20 2016, 11:47 AM
vitalybuka edited edge metadata.
This revision is now accepted and ready to land.Sep 20 2016, 11:47 AM
Closed by commit rL282012: [asan] Fix GlobalAddressDescription::Print() (authored by filcab). · Explain WhySep 20 2016, 1:42 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lib/
asan/
3 lines
test/
asan/
TestCases/
12 lines

Diff 71956

lib/asan/asan_descriptions.cc

Show First 20 Lines • Show All 317 Lines • ▼ Show 20 Lines
void ShadowAddressDescription::Print() const { void ShadowAddressDescription::Print() const {
Printf("Address %p is located in the %s area.\n", addr, ShadowNames[kind]); Printf("Address %p is located in the %s area.\n", addr, ShadowNames[kind]);
} }
void GlobalAddressDescription::Print(const char *bug_type) const { void GlobalAddressDescription::Print(const char *bug_type) const {
for (int i = 0; i < size; i++) { for (int i = 0; i < size; i++) {
DescribeAddressRelativeToGlobal(addr, access_size, globals[i]); DescribeAddressRelativeToGlobal(addr, access_size, globals[i]);
if (0 == internal_strcmp(bug_type, "initialization-order-fiasco") && if (bug_type &&
0 == internal_strcmp(bug_type, "initialization-order-fiasco") &&
reg_sites[i]) { reg_sites[i]) {
Printf(" registered at:\n"); Printf(" registered at:\n");
StackDepotGet(reg_sites[i]).Print(); StackDepotGet(reg_sites[i]).Print();
} }
} }
} }
void StackAddressDescription::Print() const { void StackAddressDescription::Print() const {
▲ Show 20 Lines • Show All 151 Lines • Show Last 20 Lines

test/asan/TestCases/global-address.cpp

  • This file was added.
// RUN: %clangxx_asan -o %t %s
// RUN: not %run %t | FileCheck %s
#include <sanitizer/allocator_interface.h>
int g_i = 42;
int main() {
// CHECK: AddressSanitizer: attempting to call __sanitizer_get_allocated_size() for pointer which is not owned
// CHECK-NOT: ASAN:DEADLYSIGNAL
// CHECK: SUMMARY: AddressSanitizer: bad-__sanitizer_get_allocated_size
// CHECK-NOT: ASAN:DEADLYSIGNAL
return (int)__sanitizer_get_allocated_size(&g_i);
}