Page MenuHomePhabricator

AMDGPU: Improve documentation.
ClosedPublic

Authored by nhaustov on Sep 19 2016, 5:41 AM.

Details

Summary

Add links to ISA manuals and ABI.
Add text about assembler syntax.
Add info about instructions operands.
Add instruction examples for each encoding.
Update directives section, add missing .amdgpu_hsa_kernel.

Diff Detail

Repository
rL LLVM

Event Timeline

nhaustov updated this revision to Diff 71816.Sep 19 2016, 5:41 AM
nhaustov retitled this revision from to AMDGPU: Improve documentation..
nhaustov updated this object.
nhaustov added subscribers: llvm-commits, artem.tamazov.
nhaustov updated this revision to Diff 71817.Sep 19 2016, 5:43 AM

Add generated html file for easy review (will be removed in the commit).

SamWot accepted this revision.Sep 19 2016, 7:49 AM
SamWot edited edge metadata.

LGTM

This revision is now accepted and ready to land.Sep 19 2016, 7:49 AM
artem.tamazov added inline comments.Sep 19 2016, 12:25 PM
docs/AMDGPUUsage.rst
73 ↗(On Diff #71817)

I would add quotes around off.

docs/AMDGPUUsage.rst
11–19 ↗(On Diff #71817)

The convention is to put these in CompilerWriterInfo.rst Maybe we move these to this file and then add a link to it.

This revision was automatically updated to reflect the committed changes.