This is an archive of the discontinued LLVM Phabricator instance.

Differential D24320

[compiler-rt] Don't use -fPIC when building for Windows
ClosedPublic

Authored by fjricci on Sep 7 2016, 3:32 PM.

Details

Reviewers
compnerd
kubamracek
beanz
Commits
rG0b6f487c639e: [compiler-rt] Don't use -fPIC when building for Windows
rCRT280953: [compiler-rt] Don't use -fPIC when building for Windows
rL280953: [compiler-rt] Don't use -fPIC when building for Windows
Summary

This flag doesn't make sense on Windows systems.

Diff Detail

Event Timeline

fjricci updated this revision to Diff 70609.Sep 7 2016, 3:32 PM
fjricci retitled this revision from to [compiler-rt] Don't use -fPIC when building for Windows.
fjricci updated this object.
fjricci added reviewers: beanz, kubamracek, compnerd.
fjricci added a subscriber: llvm-commits.
Herald added subscribers: beanz, dberris. · View Herald TranscriptSep 7 2016, 3:32 PM
compnerd accepted this revision.Sep 7 2016, 3:36 PM
compnerd edited edge metadata.
This revision is now accepted and ready to land.Sep 7 2016, 3:36 PM
Closed by commit rL280953: [compiler-rt] Don't use -fPIC when building for Windows (authored by fjricci). · Explain WhySep 8 2016, 9:05 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
4 lines

Diff 70609

CMakeLists.txt

Show First 20 Lines • Show All 123 Lines • ▼ Show 20 Lines
append_string_if(COMPILER_RT_HAS_STD_CXX11_FLAG -std=c++11 CMAKE_CXX_FLAGS) append_string_if(COMPILER_RT_HAS_STD_CXX11_FLAG -std=c++11 CMAKE_CXX_FLAGS)
# Emulate C99 and C++11's __func__ for MSVC prior to 2013 CTP. # Emulate C99 and C++11's __func__ for MSVC prior to 2013 CTP.
if(NOT COMPILER_RT_HAS_FUNC_SYMBOL) if(NOT COMPILER_RT_HAS_FUNC_SYMBOL)
add_definitions(-D__func__=__FUNCTION__) add_definitions(-D__func__=__FUNCTION__)
endif() endif()
# Provide some common commmandline flags for Sanitizer runtimes. # Provide some common commmandline flags for Sanitizer runtimes.
if(NOT WIN32)
append_list_if(COMPILER_RT_HAS_FPIC_FLAG -fPIC SANITIZER_COMMON_CFLAGS) append_list_if(COMPILER_RT_HAS_FPIC_FLAG -fPIC SANITIZER_COMMON_CFLAGS)
endif()
append_list_if(COMPILER_RT_HAS_FNO_BUILTIN_FLAG -fno-builtin SANITIZER_COMMON_CFLAGS) append_list_if(COMPILER_RT_HAS_FNO_BUILTIN_FLAG -fno-builtin SANITIZER_COMMON_CFLAGS)
append_list_if(COMPILER_RT_HAS_FNO_EXCEPTIONS_FLAG -fno-exceptions SANITIZER_COMMON_CFLAGS) append_list_if(COMPILER_RT_HAS_FNO_EXCEPTIONS_FLAG -fno-exceptions SANITIZER_COMMON_CFLAGS)
if(NOT COMPILER_RT_DEBUG) if(NOT COMPILER_RT_DEBUG)
append_list_if(COMPILER_RT_HAS_FOMIT_FRAME_POINTER_FLAG -fomit-frame-pointer SANITIZER_COMMON_CFLAGS) append_list_if(COMPILER_RT_HAS_FOMIT_FRAME_POINTER_FLAG -fomit-frame-pointer SANITIZER_COMMON_CFLAGS)
endif() endif()
append_list_if(COMPILER_RT_HAS_FUNWIND_TABLES_FLAG -funwind-tables SANITIZER_COMMON_CFLAGS) append_list_if(COMPILER_RT_HAS_FUNWIND_TABLES_FLAG -funwind-tables SANITIZER_COMMON_CFLAGS)
append_list_if(COMPILER_RT_HAS_FNO_STACK_PROTECTOR_FLAG -fno-stack-protector SANITIZER_COMMON_CFLAGS) append_list_if(COMPILER_RT_HAS_FNO_STACK_PROTECTOR_FLAG -fno-stack-protector SANITIZER_COMMON_CFLAGS)
append_list_if(COMPILER_RT_HAS_FNO_SANITIZE_SAFE_STACK_FLAG -fno-sanitize=safe-stack SANITIZER_COMMON_CFLAGS) append_list_if(COMPILER_RT_HAS_FNO_SANITIZE_SAFE_STACK_FLAG -fno-sanitize=safe-stack SANITIZER_COMMON_CFLAGS)
▲ Show 20 Lines • Show All 102 Lines • Show Last 20 Lines