This is an archive of the discontinued LLVM Phabricator instance.

[ARM] ARM-specific attributes should be accepted for big-endian
ClosedPublic

Authored by olista01 on Sep 6 2016, 2:21 AM.

Details

Summary

The ARM-specific C attributes (currently just interrupt) need to check
for both the big- and little-endian versions of the triples, so that
they are accepted for both big and little endian targets.

TargetWindows and TargetMicrosoftCXXABI also only use the little-endian
triples, but this is correct as windows is not supported on big-endian
ARM targets (and this is asserted in lib/Basic/Targets.cpp).

Diff Detail

Repository
rL LLVM

Event Timeline

olista01 updated this revision to Diff 70364.Sep 6 2016, 2:21 AM
olista01 retitled this revision from to [ARM] ARM-specific attributes should be accepted for big-endian.
olista01 updated this object.
olista01 added reviewers: rengolin, t.p.northover.
olista01 set the repository for this revision to rL LLVM.
olista01 added a subscriber: cfe-commits.
rovka accepted this revision.Sep 14 2016, 8:47 AM
rovka added a reviewer: rovka.
rovka added a subscriber: rovka.

Looks like a sensible thing to do.

This revision is now accepted and ready to land.Sep 14 2016, 8:47 AM
This revision was automatically updated to reflect the committed changes.