This is an archive of the discontinued LLVM Phabricator instance.

Differential D23975

Support of kfreebsd & GNU Hurd in llvm-shlib
Needs ReviewPublic

Authored by pinotree on Aug 28 2016, 2:08 PM.

Download Raw Diff

Details

Reviewers

beanz
sylvestre.ledru

Summary

Use the right link flags, so the resulting libLLVM-X.Y has all the proper symbols
Patch by Pino Toscano. Reported in http://bugs.debian.org/835665

Diff Detail

Repository: rL LLVM

Event Timeline

sylvestre.ledru updated this revision to Diff 69520.Aug 28 2016, 2:08 PM

sylvestre.ledru retitled this revision from to Support of kfreebsd & GNU Hurd in llvm-shlib.

sylvestre.ledru updated this object.

sylvestre.ledru added a reviewer: beanz.

sylvestre.ledru set the repository for this revision to rL LLVM.

sylvestre.ledru added a subscriber: llvm-commits.

sylvestre.ledru updated this object.Aug 28 2016, 2:14 PM

pinotree added a subscriber: pinotree.May 5 2017, 9:35 AM

Update to the latest HEAD.

Herald added subscribers: krytarowski, mgorny. · View Herald TranscriptMay 5 2017, 11:58 AM

pinotree commandeered this revision.May 5 2017, 11:59 AM

pinotree added a reviewer: sylvestre.ledru.

Update revision.

I think it is now fixed

Herald added a subscriber: mstorsjo. · View Herald TranscriptOct 31 2020, 4:07 AM

Revision Contents

Path

Size

tools/

llvm-shlib/

2 lines

Diff 69520

tools/llvm-shlib/CMakeLists.txt

Context not available.
	add_llvm_library(LLVM SHARED DISABLE_LLVM_LINK_LLVM_DYLIB SONAME ${SOURCES})			add_llvm_library(LLVM SHARED DISABLE_LLVM_LINK_LLVM_DYLIB SONAME ${SOURCES})

	list(REMOVE_DUPLICATES LIB_NAMES)			list(REMOVE_DUPLICATES LIB_NAMES)
	if("${CMAKE_SYSTEM_NAME}" STREQUAL "Linux") # FIXME: It should be "GNU ld for elf"			if("${CMAKE_SYSTEM_NAME}" STREQUAL "Linux" OR "${CMAKE_SYSTEM_NAME}" STREQUAL "GNU" OR "${CMAKE_SYSTEM_NAME}" STREQUAL "kFreeBSD") # FIXME: It should be "GNU ld for elf"
	# GNU ld doesn't resolve symbols in the version script.			# GNU ld doesn't resolve symbols in the version script.
	set(LIB_NAMES -Wl,--whole-archive ${LIB_NAMES} -Wl,--no-whole-archive)			set(LIB_NAMES -Wl,--whole-archive ${LIB_NAMES} -Wl,--no-whole-archive)
	elseif("${CMAKE_SYSTEM_NAME}" STREQUAL "Darwin")			elseif("${CMAKE_SYSTEM_NAME}" STREQUAL "Darwin")
Context not available.