This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU: Reorganize store tests
ClosedPublic

Authored by jvesely on Aug 28 2016, 12:26 AM.

Details

Diff Detail

Repository
rL LLVM

Event Timeline

jvesely updated this revision to Diff 69504.Aug 28 2016, 12:26 AM
jvesely retitled this revision from to AMDGPU: Reorganize store tests.
jvesely updated this object.
jvesely set the repository for this revision to rL LLVM.
jvesely edited edge metadata.Aug 28 2016, 12:26 AM
jvesely added a subscriber: arsenm.

ping. this is just moving tests around

arsenm added inline comments.Sep 1 2016, 4:24 PM
test/CodeGen/AMDGPU/store-global.ll
1–2 ↗(On Diff #69504)

If you're moving the tests around anyway, you should change the SI prefix to GCN for possible SI/VI divergence

jvesely updated this revision to Diff 70111.Sep 1 2016, 5:16 PM

s/SI/GCN/g

jvesely marked an inline comment as done.Sep 1 2016, 5:18 PM
jvesely added inline comments.
test/CodeGen/AMDGPU/store-global.ll
2–3 ↗(On Diff #70111)

done, although it breaks the nice "Moved from" line in the diff

arsenm accepted this revision.Sep 2 2016, 11:14 AM
arsenm added a reviewer: arsenm.

LGTM

This revision is now accepted and ready to land.Sep 2 2016, 11:14 AM
This revision was automatically updated to reflect the committed changes.
jvesely marked an inline comment as done.
llvm/trunk/test/CodeGen/AMDGPU/store-local.ll