This is an archive of the discontinued LLVM Phabricator instance.

[AAP] (6) Add AAP AsmParser
AbandonedPublic

Authored by edward-jones on Aug 22 2016, 8:08 AM.

Details

Reviewers
rengolin
asb
Summary

This builds on D23771, adding a basic AsmParser for AAP

Diff Detail

Event Timeline

edward-jones retitled this revision from to [AAP] (6) Add AAP AsmParser.
edward-jones updated this object.
edward-jones added reviewers: rengolin, asb.
edward-jones added subscribers: llvm-commits, simoncook.
rengolin edited edge metadata.Aug 22 2016, 9:04 AM

This seems trivial enough, looks good to me, but I'll let more people review and approve. Thanks!

simoncook added inline comments.Nov 1 2016, 3:55 PM
lib/Target/AAP/AsmParser/AAPAsmParser.cpp
195

The function above takes an argument called Imm, but this and the others take an argument called I. Given I tends to mean Instruction, perhaps renaming this argument Imm.

edward-jones edited edge metadata.

A tiny change to renamed Imm to I in the isConst function. It at least makes the naming consistent.

Rebase onto latest LLVM

edward-jones abandoned this revision.Sep 7 2021, 9:47 AM