This builds on D23771, adding a basic AsmParser for AAP
Diff Detail
Diff Detail
Event Timeline
Comment Actions
This seems trivial enough, looks good to me, but I'll let more people review and approve. Thanks!
lib/Target/AAP/AsmParser/AAPAsmParser.cpp | ||
---|---|---|
195 | The function above takes an argument called Imm, but this and the others take an argument called I. Given I tends to mean Instruction, perhaps renaming this argument Imm. |
Comment Actions
A tiny change to renamed Imm to I in the isConst function. It at least makes the naming consistent.
The function above takes an argument called Imm, but this and the others take an argument called I. Given I tends to mean Instruction, perhaps renaming this argument Imm.