This is an archive of the discontinued LLVM Phabricator instance.

[SelectionDAG] Make the world a less confusing place by renaming frnd -> fround and fround -> fpround
ClosedPublic

Authored by mkuper on Aug 16 2016, 6:14 PM.

Details

Summary

This way, the names of the tablegen defs match the names of the associated ISD nodes.

Hal, I saw you named frnd this way intentionally, because fround was already taken. Do you think renaming fround to fpround will cause more trouble than it's worth?
This will break out-of-tree backends, but it should not break them silently - the type constraints on the old fround and new fround are different, so patterns using the old fround will not compile with the new one.

Note that the confusion is not theoretical. :-) jlebar and I spent some time staring at a broken pattern until we had the "oh, this should be an *frnd*" realization.

Diff Detail

Repository
rL LLVM

Event Timeline

mkuper updated this revision to Diff 68296.Aug 16 2016, 6:14 PM
mkuper retitled this revision from to [SelectionDAG] Make the world a less confusing place by renaming frnd -> fround and fround -> fpround.
mkuper updated this object.
mkuper added reviewers: jlebar, hfinkel.
mkuper added a subscriber: llvm-commits.
jlebar accepted this revision.Aug 16 2016, 7:36 PM
jlebar edited edge metadata.

I am certainly in favor of this.

This revision is now accepted and ready to land.Aug 16 2016, 7:36 PM
This revision was automatically updated to reflect the committed changes.