This is an archive of the discontinued LLVM Phabricator instance.

[WebAssembly] Re-enable disabled debug value test
ClosedPublic

Authored by ddcc on Aug 12 2016, 11:19 AM.

Download Raw Diff

Details

Reviewers

dschuff
sunfish

Commits

rG4a9b99ee925d: [WebAssembly] Re-enable disabled debug value test
rL278576: [WebAssembly] Re-enable disabled debug value test

Summary

This test was resulting in asan/valgrind failures due to undefined
DWARF register mappings for WebAssembly, and was disabled in r278495.
These have been resolved.

Diff Detail

Repository: rL LLVM

Event Timeline

ddcc updated this revision to Diff 67867.Aug 12 2016, 11:19 AM

ddcc retitled this revision from to [WebAssembly] Re-enable disabled debug value test.

ddcc updated this object.

Herald added subscribers: dschuff, jfb. · View Herald TranscriptAug 12 2016, 11:19 AM

ddcc added a parent revision: D23458: Avoid accessing LLVM/DWARF register mappings if undefined.Aug 12 2016, 11:19 AM

ddcc added reviewers: dschuff, sunfish.

ddcc edited subscribers, added: llvm-commits, bkramer; removed: dschuff.

LGTM (after the fix has been landed obviously :)

This revision is now accepted and ready to land.Aug 12 2016, 2:56 PM

Closed by commit rL278576: [WebAssembly] Re-enable disabled debug value test (authored by ddcc). · Explain WhyAug 12 2016, 4:22 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

llvm/

trunk/

test/

CodeGen/

WebAssembly/

dbgvalue.ll

1 line

Diff 67935

llvm/trunk/test/CodeGen/WebAssembly/dbgvalue.ll

	; RUN: llc < %s -O0 -verify-machineinstrs -mtriple=wasm32-unknown-unknown \| FileCheck %s			; RUN: llc < %s -O0 -verify-machineinstrs -mtriple=wasm32-unknown-unknown \| FileCheck %s
	; REQUIRES: disabled

	; CHECK: BB#0			; CHECK: BB#0
	; CHECK: #DEBUG_VALUE: usage:self <- %vreg4			; CHECK: #DEBUG_VALUE: usage:self <- %vreg4
	; CHECK: BB#1			; CHECK: BB#1
	; CHECK: DW_TAG_variable			; CHECK: DW_TAG_variable
	target datalayout = "e-m:e-p:32:32-i64:64-n32:64-S128"			target datalayout = "e-m:e-p:32:32-i64:64-n32:64-S128"
	target triple = "wasm32-unknown-unknown"			target triple = "wasm32-unknown-unknown"

	▲ Show 20 Lines • Show All 61 Lines • Show Last 20 Lines