This is an archive of the discontinued LLVM Phabricator instance.

Differential D23228

[libcxxabi] Do not depend on unwind when building standalone
ClosedPublic

Authored by phosek on Aug 5 2016, 2:48 PM.

Details

Reviewers
compnerd
EricWF
Commits
rGdaee3be36437: Do not depend on unwind when building standalone
rCXXA278058: Do not depend on unwind when building standalone
rL278058: Do not depend on unwind when building standalone
Summary

When libcxxabi is being built standalone, unwind dependency is not available, so do not use it even when LLVM unwinder is being requested.

Diff Detail

Event Timeline

phosek updated this revision to Diff 67022.Aug 5 2016, 2:48 PM
phosek retitled this revision from to Do not depend on unwind when building standalone.
phosek updated this object.
phosek added a subscriber: cfe-commits.
Eugene.Zelenko retitled this revision from Do not depend on unwind when building standalone to [libcxxabi] Do not depend on unwind when building standalone.Aug 5 2016, 4:09 PM
Eugene.Zelenko added reviewers: EricWF, compnerd.
Eugene.Zelenko set the repository for this revision to rL LLVM.
Eugene.Zelenko edited subscribers, added: llvm-commits; removed: cfe-commits.
compnerd edited edge metadata.Aug 6 2016, 10:13 AM

Why does standalone imply that the llvm unwinder is unavailable? I could have installed the unwinder previously and then use that instead of libgcc_s.

phosek added a comment.Aug 6 2016, 4:35 PM

It does not imply that libunwind.(so|a) is unavailable, but it does imply that CMake target unwind is unavailable because we're building libcxxabi as a standalone project. LIBCXXABI_TEST_DEPS is passed to check-libcxxabi as DEPENDS argument which is translated to add_dependencies invocation which is incorrect. add_lit_testsuite generates the rule for invoking lit, it does not actually generate the build rule, so target_link_libraries in this case would be also incorrect.

compnerd accepted this revision.Aug 7 2016, 9:51 PM
compnerd edited edge metadata.

Ugh. I absolutely mis-read the patch.

This revision is now accepted and ready to land.Aug 7 2016, 9:51 PM
Closed by commit rL278058: Do not depend on unwind when building standalone (authored by phosek). · Explain WhyAug 8 2016, 3:17 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
test/
7 lines

Diff 67022

test/CMakeLists.txt

Context not available.
if (NOT LIBCXXABI_BUILT_STANDALONE) if (NOT LIBCXXABI_BUILT_STANDALONE)
list(APPEND LIBCXXABI_TEST_DEPS cxx) list(APPEND LIBCXXABI_TEST_DEPS cxx)
endif() if (LIBCXXABI_USE_LLVM_UNWINDER)
list(APPEND LIBCXXABI_TEST_DEPS unwind)
if (LIBCXXABI_USE_LLVM_UNWINDER) endif()
list(APPEND LIBCXXABI_TEST_DEPS unwind)
endif() endif()
add_lit_testsuite(check-libcxxabi "Running libcxxabi tests" add_lit_testsuite(check-libcxxabi "Running libcxxabi tests"
Context not available.