Page MenuHomePhabricator

[ADT] Change iterator_adaptor_base's default template arguments to forward more underlying typedefs
ClosedPublic

Authored by timshen on Aug 5 2016, 11:22 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

timshen updated this revision to Diff 66983.Aug 5 2016, 11:22 AM
timshen retitled this revision from to [ADT] Change iterator_adaptor_base's default template arguments to forward more underlying typedefs.
timshen updated this object.
timshen added a reviewer: chandlerc.
timshen added a subscriber: llvm-commits.
timshen updated this revision to Diff 66986.Aug 5 2016, 11:40 AM

Added a test.

timshen updated this revision to Diff 66987.Aug 5 2016, 11:44 AM

Make test compile :P.

dblaikie accepted this revision.Aug 9 2016, 11:53 AM
dblaikie edited edge metadata.
dblaikie added inline comments.
unittests/Support/IteratorTest.cpp
101 ↗(On Diff #66987)

This doesn't need to be in a test case, since none of it executes dynamically - probably just put it in a namespace (so it doesn't provide any names that might interfere with other tests)

103 ↗(On Diff #66987)

Maybe worth introducing some arbitrary tag types (just random structs with helpful names like ValueType, PointerType, DifferenceType, ReferenceType) rather than using all ints - so it's clear the types aren't getting mismatched or anything?

This revision is now accepted and ready to land.Aug 9 2016, 11:53 AM
timshen updated this revision to Diff 67402.Aug 9 2016, 1:09 PM
timshen edited edge metadata.

Moved the compile-time test to the outer anonymous namespace.

timshen marked 2 inline comments as done.Aug 9 2016, 1:09 PM