Page MenuHomePhabricator

[ADT] Change iterator_adaptor_base's default template arguments to forward more underlying typedefs
ClosedPublic

Authored by timshen on Aug 5 2016, 11:28 AM.

Details

Summary

The corresponding LLVM change: D23217.

LazyVector::iterator breaks, because int isn't an iterator type.
Since iterator_adaptor_base shouldn't be blamed to break at the call to
iterator_traits<int>::xxx, I'd rather "fix" LazyVector::iterator.

The perfect solution is to model "relative pointer", but it's beyond the goal of this patch.

Diff Detail

Repository
rL LLVM

Event Timeline

timshen updated this revision to Diff 66984.Aug 5 2016, 11:28 AM
timshen retitled this revision from to [ADT] Change iterator_adaptor_base's default template arguments to forward more underlying typedefs.
timshen updated this object.
timshen added reviewers: chandlerc, bkramer.
timshen added a subscriber: cfe-commits.
bkramer accepted this revision.Aug 5 2016, 11:32 AM
bkramer edited edge metadata.
This revision is now accepted and ready to land.Aug 5 2016, 11:32 AM
This revision was automatically updated to reflect the committed changes.