This is an archive of the discontinued LLVM Phabricator instance.

[ADT] NFC: Generalize GraphTraits requirement of "NodeType *" in interfaces to "NodeRef", and migrate SCCIterator.h to use NodeRef
ClosedPublic

Authored by timshen on Jul 28 2016, 2:32 PM.

Details

Summary

By generalize the interface, users are able to inject more flexible Node token into the algorithm, for example, a pair of vector<Node>* and index integer. Currently I only migrated SCCIterator to use NodeRef, but more is coming. It's a NFC.

Diff Detail

Repository
rL LLVM

Event Timeline

timshen updated this revision to Diff 66005.Jul 28 2016, 2:32 PM
timshen retitled this revision from to [ADT] NFC: Generalize GraphTraits requirement of "NodeType *" in interfaces to "NodeRef", and migrate SCCIterator.h to use NodeRef.
timshen updated this object.
timshen added reviewers: dblaikie, chandlerc.
timshen added a subscriber: llvm-commits.
dblaikie accepted this revision.Aug 1 2016, 3:03 PM
dblaikie edited edge metadata.
This revision is now accepted and ready to land.Aug 1 2016, 3:03 PM
This revision was automatically updated to reflect the committed changes.