This is an archive of the discontinued LLVM Phabricator instance.

change Vim key binding for include-fixer and clang-rename
ClosedPublic

Authored by omtcyfz on Jul 27 2016, 5:01 AM.

Details

Summary

Change Vim key binding for include-fixer (,cf -> <leader>cf) and clang-rename (,cr -> <leader>cr) to use <leader> instead of , like cool Vim people (tm) do.

Diff Detail

Event Timeline

omtcyfz updated this revision to Diff 65708.Jul 27 2016, 5:01 AM
omtcyfz retitled this revision from to change Vim key binding for include-fixer and clang-rename.
omtcyfz updated this object.
omtcyfz added reviewers: alexfh, klimek, ioeric.
omtcyfz added a reviewer: bkramer.
omtcyfz added a subscriber: cfe-commits.
ioeric edited edge metadata.Jul 27 2016, 5:13 AM

Could you briefly explain what <leader> is and how to lookup/set it in the doc, or at least provide reference?

:help leader explains it. Or see this link: http://learnvimscriptthehardway.stevelosh.com/chapters/06.html#leader. The later describes 3 arguments for using <leader> instead of , directly.

omtcyfz updated this revision to Diff 65714.Jul 27 2016, 5:43 AM
omtcyfz edited edge metadata.

add refernce to what <leader> is

:help leader explains it. Or see this link: http://learnvimscriptthehardway.stevelosh.com/chapters/06.html#leader. The later describes 3 arguments for using <leader> instead of , directly.

I think the point was to put that into documentation :)

Any other comments?

ioeric added inline comments.Jul 27 2016, 7:10 AM
docs/clang-rename.rst
98

s/the symbols/symbols/

101

s/a reference to //

sounds redundant..

docs/include-fixer.rst
69

s/a reference to //

omtcyfz updated this revision to Diff 65739.Jul 27 2016, 7:17 AM
omtcyfz marked an inline comment as done.
omtcyfz added inline comments.
docs/clang-rename.rst
101

Why does it?

Key is a key; key can't be assigned to anything. Reference can be changed to any other key.

ioeric accepted this revision.Jul 27 2016, 7:22 AM
ioeric edited edge metadata.

lgtm

docs/clang-rename.rst
101

Didn't see it was "<leader> key"... thought it was just "<leader>".

nvm, not important :)

This revision is now accepted and ready to land.Jul 27 2016, 7:22 AM
alexfh added inline comments.Jul 27 2016, 7:26 AM
docs/include-fixer.rst
69

s/binded/bound/
Same elsewhere.

omtcyfz added inline comments.Jul 27 2016, 7:27 AM
docs/clang-rename.rst
101

Okay, thank you :)

This revision was automatically updated to reflect the committed changes.