Added 'inline' attribute to basic_string's destructor

[laxmansole]

Summary

Currently basic_string's destructor is not getting inlined. So adding 'inline' attribute to ~basic_string().

Worked in collaboration with Aditya Kumar.

[EricWF]

LGTM.

However I would like to see a small benchmark that demonstrates the performance change. Please try and write the benchmark using Google Benchmark.
Some helpful links:

http://libcxx.llvm.org/docs/TestingLibcxx.html#building-benchmarks
http://github.com/google/benchmark

Let me know if I can help.

[hiraditya]

In D22834#504425, @EricWF wrote:

LGTM.

However I would like to see a small benchmark that demonstrates the performance change. Please try and write the benchmark using Google Benchmark.
Some helpful links:

http://libcxx.llvm.org/docs/TestingLibcxx.html#building-benchmarks
http://github.com/google/benchmark

Let me know if I can help.

Sure,
We'll come up with a synthetic benchmark to expose performance improvements.

Thanks,

[hiraditya]

In D22834#504425, @EricWF wrote:

LGTM.

However I would like to see a small benchmark that demonstrates the performance change. Please try and write the benchmark using Google Benchmark.
Some helpful links:

http://libcxx.llvm.org/docs/TestingLibcxx.html#building-benchmarks
http://github.com/google/benchmark

Let me know if I can help.

Hi Eric,
Is this also good to merge.

Thanks,
-Aditya

[laxmansole]

Ping

[mclow.lists]

@EricWF - did you want to see a benchmark as part of this commit?

[EricWF]

No benchmark needed but one would be appreciated if possible.

[hiraditya]

In D22834#522499, @EricWF wrote:

No benchmark needed but one would be appreciated if possible.

I guess @laxmansole sent you a synthetic benchmark because we were having trouble integrating it to the libcxx testsuite. I can send you that again which can be submitted as a separate patch if you want.

libcxx/include/string

 #if _LIBCPP_DEBUG_LEVEL >= 2
     __get_db()->__insert_c(this);
 #endif
 }
 
 #endif  // _LIBCPP_HAS_NO_GENERALIZED_INITIALIZERS
 
 template <class _CharT, class _Traits, class _Allocator>
+inline _LIBCPP_INLINE_VISIBILITY
 basic_string<_CharT, _Traits, _Allocator>::~basic_string()
 {
 #if _LIBCPP_DEBUG_LEVEL >= 2
     __get_db()->__erase_c(this);
 #endif
     if (__is_long())
         __alloc_traits::deallocate(__alloc(), __get_long_pointer(), __get_long_cap());
 }