This is an archive of the discontinued LLVM Phabricator instance.

[ARM] Improve error messages for .arch_extension directive
ClosedPublic

Authored by olista01 on Jul 26 2016, 6:41 AM.

Details

Summary
  • More informative message when extension name is not an identifier token.
  • Stop parsing directive if extension is unknown (avoid duplicate error messages).
  • Report unsupported extensions with a source location, rather than report_fatal_error.

Diff Detail

Event Timeline

olista01 updated this revision to Diff 65505.Jul 26 2016, 6:41 AM
olista01 retitled this revision from to [ARM] Improve error messages for .arch_extension directive.
olista01 updated this object.
olista01 added reviewers: t.p.northover, rengolin.
olista01 set the repository for this revision to rL LLVM.
olista01 added a subscriber: llvm-commits.
rengolin accepted this revision.Jul 26 2016, 6:54 AM
rengolin edited edge metadata.

Much better, thanks! LGTM with the additional test.

test/MC/ARM/directive-arch_extension-unsupported.s
2

not testing empty one?

This revision is now accepted and ready to land.Jul 26 2016, 6:54 AM
This revision was automatically updated to reflect the committed changes.