[libcxx] Add "flag" default arg: basic_regex ptr_size_flag ctor

[jasonliu]

Summary

The synopsis in C++11 subclause 28.8 [re.regex] has:

basic_regex(const charT* p, size_t len, flag_type f = regex_constants::ECMAScript);

The default argument is added to libc++ by this change.

[hubert.reinterpretcast]

Minor concerns noted. I'd be okay with this patch, but would like someone else to give the okay (or indicate what issues need to be addressed).

include/regex

148

This line has more than 80 characters; however, the file already has such lines. I guess the libc++ project does not enforce the 80-column policy.

test/std/re/re.regex/re.regex.construct/ptr_size.pass.cpp

31

This appears (like ptr_size_flg.pass.cpp) to neglect testing size in favour of testing flg. Which is to say that, perhaps size should not always be strlen(ptr).

[jasonliu]

Address @hubert.reinterpretcast 's comment about the test case. Added more cases to test "size" parameter in the constructor.

[jasonliu]

test/std/re/re.regex/re.regex.construct/ptr_size.pass.cpp

31

Comment addressed in the new patch. Thanks!

[jasonliu]

Gentle ping?

[hubert.reinterpretcast]

LGTM.