The synopsis in C++11 subclause 28.8 [re.regex] has:
basic_regex(const charT* p, size_t len, flag_type f = regex_constants::ECMAScript);
The default argument is added to libc++ by this change.
Differential D22702
[libcxx] Add "flag" default arg: basic_regex ptr_size_flag ctor jasonliu on Jul 22 2016, 2:26 PM. Authored by
Details
The synopsis in C++11 subclause 28.8 [re.regex] has: basic_regex(const charT* p, size_t len, flag_type f = regex_constants::ECMAScript); The default argument is added to libc++ by this change.
Diff Detail Event TimelineComment Actions Minor concerns noted. I'd be okay with this patch, but would like someone else to give the okay (or indicate what issues need to be addressed).
Comment Actions Address @hubert.reinterpretcast 's comment about the test case. Added more cases to test "size" parameter in the constructor.
|