Page MenuHomePhabricator

[libcxx] Add "flag" default arg: basic_regex ptr_size_flag ctor
ClosedPublic

Authored by jasonliu on Jul 22 2016, 2:26 PM.

Diff Detail

Event Timeline

jasonliu updated this revision to Diff 65154.Jul 22 2016, 2:26 PM
jasonliu retitled this revision from to [libcxx]Missing default argument for flag_type parameter in one of std::basic_regex constructors.
jasonliu updated this object.
jasonliu added a subscriber: cfe-commits.

Minor concerns noted. I'd be okay with this patch, but would like someone else to give the okay (or indicate what issues need to be addressed).

include/regex
148

This line has more than 80 characters; however, the file already has such lines. I guess the libc++ project does not enforce the 80-column policy.

test/std/re/re.regex/re.regex.construct/ptr_size.pass.cpp
30

This appears (like ptr_size_flg.pass.cpp) to neglect testing size in favour of testing flg. Which is to say that, perhaps size should not always be strlen(ptr).

jasonliu updated this revision to Diff 66153.Jul 29 2016, 11:44 AM
jasonliu edited edge metadata.

Address @hubert.reinterpretcast 's comment about the test case. Added more cases to test "size" parameter in the constructor.

jasonliu marked an inline comment as done.Jul 29 2016, 11:45 AM
jasonliu added inline comments.
test/std/re/re.regex/re.regex.construct/ptr_size.pass.cpp
32

Comment addressed in the new patch. Thanks!

jasonliu marked an inline comment as done.Aug 5 2016, 8:37 AM

Gentle ping?

This revision is now accepted and ready to land.Aug 7 2016, 8:29 AM
hubert.reinterpretcast retitled this revision from [libcxx]Missing default argument for flag_type parameter in one of std::basic_regex constructors to [libcxx] Add "flag" default arg: basic_regex ptr_size_flag ctor.Aug 7 2016, 2:46 PM
hubert.reinterpretcast updated this object.
hubert.reinterpretcast edited edge metadata.