This is an archive of the discontinued LLVM Phabricator instance.

[ELF/Linkerscript] Define an absolute if we find an undefined during symbol assignment
ClosedPublic

Authored by davide on Jul 21 2016, 10:25 PM.

Diff Detail

Event Timeline

davide updated this revision to Diff 65027.Jul 21 2016, 10:25 PM
davide retitled this revision from to [ELF/Linkerscript] Define an absolute if we find an undefined during symbol assignment.
davide updated this object.
davide added a reviewer: ruiu.
davide added a subscriber: llvm-commits.
grimar added a subscriber: grimar.Jul 22 2016, 1:54 AM
emaste added a subscriber: emaste.Jul 22 2016, 6:07 AM

Conflicts with recently committed rL276398

davide updated this revision to Diff 65107.Jul 22 2016, 11:16 AM
ruiu accepted this revision.Jul 23 2016, 4:04 AM
ruiu edited edge metadata.

LGTM

ELF/LinkerScript.cpp
536–539

I think we usually write !B instead of B == nullptr.

This revision is now accepted and ready to land.Jul 23 2016, 4:04 AM
This revision was automatically updated to reflect the committed changes.