This is an archive of the discontinued LLVM Phabricator instance.

[compiler-rt] Fix broken unittest related to 64-bit print format
ClosedPublic

Authored by etienneb on Jul 20 2016, 1:30 PM.

Reviewers

Commits

Summary

The printf is not working correctly on 64-bit MSVC.

The portable way to print "size_t" is to use "%zx" (size_t in hexa).

etienneb retitled this revision from to [compiler-rt] Fix broken unittest related to 64-bit print format.

etienneb updated this object.

etienneb added a reviewer: rnk.

lgtm

This revision is now accepted and ready to land.Jul 20 2016, 1:42 PM

fix an other test

lgtm

test/asan/TestCases/debug_stacks.cc
52 ↗	(On Diff #64755)	very fancy :)

Path

Size

test/

asan/

TestCases/

2 lines

	Show All 9 Lines
	// CHECK: SHADOW_SCALE: [[SCALE:[0-9]+]]			// CHECK: SHADOW_SCALE: [[SCALE:[0-9]+]]
	// CHECK: SHADOW_OFFSET: [[OFFSET:0x[0-9a-f]+]]			// CHECK: SHADOW_OFFSET: [[OFFSET:0x[0-9a-f]+]]

	int main() {			int main() {
	size_t scale, offset;			size_t scale, offset;
	__asan_get_shadow_mapping(&scale, &offset);			__asan_get_shadow_mapping(&scale, &offset);

	fprintf(stderr, "scale: %d\n", (int)scale);			fprintf(stderr, "scale: %d\n", (int)scale);
	fprintf(stderr, "offset: 0x%lx\n", offset);			fprintf(stderr, "offset: 0x%zx\n", offset);

	// CHECK: scale: [[SCALE]]			// CHECK: scale: [[SCALE]]
	// CHECK: offset: [[OFFSET]]			// CHECK: offset: [[OFFSET]]

	return 0;			return 0;
	}			}