This is an archive of the discontinued LLVM Phabricator instance.

[compiler-rt] Fix Asan imports/exports unittest
ClosedPublic

Authored by etienneb on Jul 18 2016, 3:23 PM.

Details

Summary

Avoid mismatch between imports/exports for 32-bit and 64-bits version.

The test is running grep over macros to detect which functions are
intercepted. Unfortunately, exception handlers differ in 32-bit and
64-bit.

This patch is removing the exception handlers from the test.

Diff Detail

Event Timeline

etienneb updated this revision to Diff 64396.Jul 18 2016, 3:23 PM
etienneb retitled this revision from to [compiler-rt] Fix Asan imports/exports unittest.
etienneb updated this object.
etienneb added a reviewer: rnk.
etienneb updated this revision to Diff 64500.Jul 19 2016, 7:48 AM

better solution

rnk accepted this revision.Jul 19 2016, 7:54 AM
rnk edited edge metadata.

lgtm

test/asan/TestCases/Windows/dll_host.cc
8

Can you comment that we're removing the "@12" part of the 32-bit exported mangled names because it won't be mentioned in the source?

This revision is now accepted and ready to land.Jul 19 2016, 7:54 AM
etienneb updated this revision to Diff 64507.Jul 19 2016, 8:30 AM
etienneb marked an inline comment as done.
etienneb edited edge metadata.

add comments

etienneb closed this revision.Jul 19 2016, 8:34 AM
etienneb marked an inline comment as not done.