Page MenuHomePhabricator

FileCheck Enhancement - repeats in regular expressions
AbandonedPublic

Authored by eklepilkina on Jul 14 2016, 1:04 AM.

Details

Summary

Repeat with current number should become available by using {n}, {n,m} , {,n}, {n,}

Diff Detail

Event Timeline

eklepilkina retitled this revision from to FileCheck Enhancement - repeats in regular expressions.
eklepilkina updated this object.
eklepilkina changed the edit policy from "All Users" to "Administrators".
eklepilkina added a subscriber: vsk.
jyknight added inline comments.Jul 14 2016, 8:56 AM
utils/FileCheck/FileCheck.cpp
240

Comment for what this is doing (skipping to the end of a sequence of consecutive }s.)

254

Putting this in FileCheck is a bad hack. It is the wrong place to make a regexp syntax change.

Either users can simply use {0,N}, or we could change our regexp implementation to support {,N}.

eklepilkina marked an inline comment as done.Jul 14 2016, 11:51 PM
eklepilkina added inline comments.
utils/FileCheck/FileCheck.cpp
254

Ok, I'll remove this and it will be able to use only {0,n} in such cases. In my opinion, it's a great idea to change regexp library, because current library is quite old and has unsupported useful regexp features.

eklepilkina abandoned this revision.Jul 18 2016, 1:22 AM