Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

People eklepilkina

eklepilkina (Elena Lepilkina)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 18 2016, 7:25 AM (388 w, 4 d)

Recent Activity
View All

May 31 2023

eklepilkina accepted D151716: [RISCV] check pointer before dereference.
May 31 2023, 3:40 AM · Restricted Project, Restricted Project

May 17 2023

eklepilkina added a comment to D146138: [LoopIdiomRecognize] Optimize cases when loop contains extra stores and loads.

Gently ping

May 17 2023, 11:50 PM · Restricted Project, Restricted Project

Apr 20 2023

eklepilkina abandoned D141666: [RISCV] Proper support of extensions Zicsr and Zifencei.

Another implementation was merged to upsteam

Apr 20 2023, 5:59 AM · Restricted Project, Restricted Project, Restricted Project

Mar 27 2023

eklepilkina added a comment to D146138: [LoopIdiomRecognize] Optimize cases when loop contains extra stores and loads.

Gently ping

Mar 27 2023, 12:18 AM · Restricted Project, Restricted Project

Mar 15 2023

eklepilkina retitled D146138: [LoopIdiomRecognize] Optimize cases when loop contains extra stores and loads from [LoopIdiomRecognize] Precommit tests for store/loads that don't alias same memory location to [LoopIdiomRecognize] Optimize cases when loop contains extra stores and loads.
Mar 15 2023, 7:43 AM · Restricted Project, Restricted Project
eklepilkina added reviewers for D146138: [LoopIdiomRecognize] Optimize cases when loop contains extra stores and loads: chandlerc, anton-afanasyev, craig.topper, haicheng.
Mar 15 2023, 7:31 AM · Restricted Project, Restricted Project
eklepilkina requested review of D146138: [LoopIdiomRecognize] Optimize cases when loop contains extra stores and loads.
Mar 15 2023, 7:22 AM · Restricted Project, Restricted Project

Feb 28 2023

eklepilkina added a comment to D142191: [lld][RISCV] Merge subtarget features to get right attributes section.

It is not correct to assume that the mere presence of a function with extra attributes changes the requirement of the module.

Feb 28 2023, 11:24 PM · Restricted Project, Restricted Project
eklepilkina added a comment to D139704: [clang][RISCV] Added target attributes to runtime functions.

Gently ping

Feb 28 2023, 11:15 PM · Restricted Project, Restricted Project
eklepilkina added a comment to D141666: [RISCV] Proper support of extensions Zicsr and Zifencei.

Gently ping

Feb 28 2023, 11:14 PM · Restricted Project, Restricted Project, Restricted Project

Feb 15 2023

eklepilkina updated the diff for D141666: [RISCV] Proper support of extensions Zicsr and Zifencei.
  • [RISCV] Prepare work to be ready for adding separate Zicsr and Zifencei extensions
  • [RISCV] Proper support of extensions Zicsr and Zifencei
  • Updated I extension verson
  • Fixing after updating
Feb 15 2023, 3:35 AM · Restricted Project, Restricted Project, Restricted Project

Feb 14 2023

eklepilkina added a comment to D141666: [RISCV] Proper support of extensions Zicsr and Zifencei.

@reames Thank you for fixing documentation, missed this

Feb 14 2023, 6:36 AM · Restricted Project, Restricted Project, Restricted Project

Feb 2 2023

eklepilkina added a comment to D130769: [RISCV] Combine and remove redundant ADD/SUB instructions.

Gently ping

Feb 2 2023, 6:51 AM · Restricted Project, Restricted Project
eklepilkina added a comment to D139704: [clang][RISCV] Added target attributes to runtime functions.

Gently ping

Feb 2 2023, 6:50 AM · Restricted Project, Restricted Project
eklepilkina added a comment to D141666: [RISCV] Proper support of extensions Zicsr and Zifencei.

Gently ping

Feb 2 2023, 6:44 AM · Restricted Project, Restricted Project, Restricted Project
eklepilkina added a comment to D142191: [lld][RISCV] Merge subtarget features to get right attributes section.

Could you please answer the question above?

Feb 2 2023, 6:43 AM · Restricted Project, Restricted Project

Jan 20 2023

eklepilkina added a comment to D141666: [RISCV] Proper support of extensions Zicsr and Zifencei.

Maybe multi-lib handling should split into another patch?

Jan 20 2023, 9:15 AM · Restricted Project, Restricted Project, Restricted Project
eklepilkina added a comment to D142191: [lld][RISCV] Merge subtarget features to get right attributes section.

Target features in a function must not leak outside a function.

Jan 20 2023, 4:06 AM · Restricted Project, Restricted Project
eklepilkina added a comment to D139704: [clang][RISCV] Added target attributes to runtime functions.

I've created one more patch connected with lto https://reviews.llvm.org/D142191 and it also uses attributes of functions as the way to get right TargetMachine in linker.

Jan 20 2023, 1:46 AM · Restricted Project, Restricted Project
eklepilkina updated the summary of D142191: [lld][RISCV] Merge subtarget features to get right attributes section.
Jan 20 2023, 1:44 AM · Restricted Project, Restricted Project
eklepilkina requested review of D142191: [lld][RISCV] Merge subtarget features to get right attributes section.
Jan 20 2023, 1:39 AM · Restricted Project, Restricted Project
eklepilkina added a comment to D139704: [clang][RISCV] Added target attributes to runtime functions.

How does this affect LTO?

Jan 20 2023, 12:28 AM · Restricted Project, Restricted Project

Jan 19 2023

eklepilkina added a comment to D139704: [clang][RISCV] Added target attributes to runtime functions.

How does this affect LTO?

Jan 19 2023, 11:48 PM · Restricted Project, Restricted Project
eklepilkina abandoned D136344: [ELF][RISCV] Merge `.riscv.attributes` sections.

Abandoned in favor of D138550

Jan 19 2023, 5:17 AM · Restricted Project, Restricted Project

Jan 18 2023

eklepilkina updated the diff for D142003: [llvm-objdump] Fix reporting error for processing target features.
  • Review fixes
Jan 18 2023, 5:30 AM · Restricted Project, Restricted Project
eklepilkina updated the diff for D142003: [llvm-objdump] Fix reporting error for processing target features.
  • Review fixes
Jan 18 2023, 5:29 AM · Restricted Project, Restricted Project
eklepilkina added a comment to D139553: [llvm-objdump][RISCV] Use new common method to parse ARCH RISCV attribute.

@foad Fixed in https://reviews.llvm.org/D142003

Jan 18 2023, 3:12 AM · Restricted Project, Restricted Project
eklepilkina added a reviewer for D142003: [llvm-objdump] Fix reporting error for processing target features: foad.
Jan 18 2023, 3:11 AM · Restricted Project, Restricted Project
eklepilkina requested review of D142003: [llvm-objdump] Fix reporting error for processing target features.
Jan 18 2023, 3:10 AM · Restricted Project, Restricted Project
eklepilkina added inline comments to D139553: [llvm-objdump][RISCV] Use new common method to parse ARCH RISCV attribute.
Jan 18 2023, 2:34 AM · Restricted Project, Restricted Project
eklepilkina added a comment to D139704: [clang][RISCV] Added target attributes to runtime functions.

Gently ping

Jan 18 2023, 12:55 AM · Restricted Project, Restricted Project
eklepilkina updated the diff for D141666: [RISCV] Proper support of extensions Zicsr and Zifencei.
  • Updated I extension verson
Jan 18 2023, 12:04 AM · Restricted Project, Restricted Project, Restricted Project

Jan 17 2023

eklepilkina added a comment to D141666: [RISCV] Proper support of extensions Zicsr and Zifencei.

Thank you for comments!

Jan 17 2023, 6:42 AM · Restricted Project, Restricted Project, Restricted Project

Jan 16 2023

eklepilkina added a comment to rG537cdf92c434: [llvm-objdump][RISCV] Use new common method to parse ARCH RISCV attribute.
Jan 16 2023, 7:54 AM · Restricted Project, Restricted Project
eklepilkina added a comment to rG537cdf92c434: [llvm-objdump][RISCV] Use new common method to parse ARCH RISCV attribute.

Thanks! Already look at the problem and waiting just local build for fix

Jan 16 2023, 7:18 AM · Restricted Project, Restricted Project

Jan 13 2023

eklepilkina updated the diff for D139553: [llvm-objdump][RISCV] Use new common method to parse ARCH RISCV attribute.
  • Review fixes
Jan 13 2023, 1:58 AM · Restricted Project, Restricted Project
eklepilkina updated subscribers of D141666: [RISCV] Proper support of extensions Zicsr and Zifencei.
Jan 13 2023, 1:18 AM · Restricted Project, Restricted Project, Restricted Project
eklepilkina added a comment to D141666: [RISCV] Proper support of extensions Zicsr and Zifencei.

We are interested in proper support for Zicsr and Zifencei. Could someone look at patch or explain why these extensions were included by default?

Jan 13 2023, 1:15 AM · Restricted Project, Restricted Project, Restricted Project
eklepilkina updated the summary of D141666: [RISCV] Proper support of extensions Zicsr and Zifencei.
Jan 13 2023, 1:10 AM · Restricted Project, Restricted Project, Restricted Project
eklepilkina requested review of D141666: [RISCV] Proper support of extensions Zicsr and Zifencei.
Jan 13 2023, 1:02 AM · Restricted Project, Restricted Project, Restricted Project

Jan 12 2023

eklepilkina updated the summary of D139553: [llvm-objdump][RISCV] Use new common method to parse ARCH RISCV attribute.
Jan 12 2023, 2:56 AM · Restricted Project, Restricted Project
eklepilkina updated the diff for D139553: [llvm-objdump][RISCV] Use new common method to parse ARCH RISCV attribute.
  • Review fixes
Jan 12 2023, 2:54 AM · Restricted Project, Restricted Project
eklepilkina updated the diff for D139553: [llvm-objdump][RISCV] Use new common method to parse ARCH RISCV attribute.
  • Review fixes
Jan 12 2023, 2:52 AM · Restricted Project, Restricted Project

Dec 18 2022

eklepilkina updated the diff for D140206: [RISCV] Omit SRA in case of setlt or setge with zero constant.

Test on bge

Dec 18 2022, 11:51 PM · Restricted Project, Restricted Project

Dec 16 2022

eklepilkina added a reviewer for D139553: [llvm-objdump][RISCV] Use new common method to parse ARCH RISCV attribute: kito-cheng.
Dec 16 2022, 7:09 AM · Restricted Project, Restricted Project
eklepilkina retitled D140206: [RISCV] Omit SRA in case of setlt or setge with zero constant from [RISCV] Ommit SRA in case of setlt or setge with zero constant to [RISCV] Omit SRA in case of setlt or setge with zero constant.
Dec 16 2022, 7:09 AM · Restricted Project, Restricted Project
eklepilkina added a reviewer for D140206: [RISCV] Omit SRA in case of setlt or setge with zero constant: reames.
Dec 16 2022, 4:57 AM · Restricted Project, Restricted Project
eklepilkina added a comment to D139553: [llvm-objdump][RISCV] Use new common method to parse ARCH RISCV attribute.

Gently ping

Dec 16 2022, 4:55 AM · Restricted Project, Restricted Project
eklepilkina added a comment to D139704: [clang][RISCV] Added target attributes to runtime functions.

Gently ping

Dec 16 2022, 4:55 AM · Restricted Project, Restricted Project
eklepilkina added a comment to D140206: [RISCV] Omit SRA in case of setlt or setge with zero constant.

During fixing this case I had a question why RISCV doesn't use SimplifySetCC from common TargetLowering. It seems that there are some cases of combinations that should work for RISCV. I tried to call it, but found cases that crashes compilations on RISCV. Are there any plans to rework this part and reuse some part of foldings from common lowering? It seems that some optimizations can be lost, doesn't it?

Dec 16 2022, 4:54 AM · Restricted Project, Restricted Project
eklepilkina updated the summary of D140206: [RISCV] Omit SRA in case of setlt or setge with zero constant.
Dec 16 2022, 4:50 AM · Restricted Project, Restricted Project
eklepilkina requested review of D140206: [RISCV] Omit SRA in case of setlt or setge with zero constant.
Dec 16 2022, 4:46 AM · Restricted Project, Restricted Project

Dec 14 2022

eklepilkina added a comment to D132843: [RISCV] Ensure target features get passed to the LTO linker for RISC-V.

@lewis-revill could you please provide the case where the LTO linker would not receive any information about target features? We met similar problems, it appears on runtime functions in our cases. I made a small fix for this problem https://reviews.llvm.org/D139704. Do you have any other problem cases?

Dec 14 2022, 2:29 AM · Restricted Project, Restricted Project

Dec 9 2022

eklepilkina added a reviewer for D139704: [clang][RISCV] Added target attributes to runtime functions: kito-cheng.
Dec 9 2022, 3:59 AM · Restricted Project, Restricted Project
eklepilkina updated the summary of D139704: [clang][RISCV] Added target attributes to runtime functions.
Dec 9 2022, 3:56 AM · Restricted Project, Restricted Project
eklepilkina requested review of D139704: [clang][RISCV] Added target attributes to runtime functions.
Dec 9 2022, 3:41 AM · Restricted Project, Restricted Project
eklepilkina added inline comments to D139553: [llvm-objdump][RISCV] Use new common method to parse ARCH RISCV attribute.
Dec 9 2022, 1:24 AM · Restricted Project, Restricted Project

Dec 8 2022

eklepilkina added inline comments to D139553: [llvm-objdump][RISCV] Use new common method to parse ARCH RISCV attribute.
Dec 8 2022, 9:13 PM · Restricted Project, Restricted Project
eklepilkina updated the diff for D139553: [llvm-objdump][RISCV] Use new common method to parse ARCH RISCV attribute.
  • Review fixes
Dec 8 2022, 9:12 PM · Restricted Project, Restricted Project
eklepilkina added a comment to D139553: [llvm-objdump][RISCV] Use new common method to parse ARCH RISCV attribute.

Updated patch, thank you @kito-cheng

Dec 8 2022, 8:02 AM · Restricted Project, Restricted Project
eklepilkina updated the diff for D139553: [llvm-objdump][RISCV] Use new common method to parse ARCH RISCV attribute.
  • Ignore unknown extensions
Dec 8 2022, 8:02 AM · Restricted Project, Restricted Project
eklepilkina added a comment to D139553: [llvm-objdump][RISCV] Use new common method to parse ARCH RISCV attribute.

I don't know how I missed this patch. @kito-cheng thanks you, if you aren't against I'll try merge these 2 patches.

Dec 8 2022, 5:33 AM · Restricted Project, Restricted Project

Dec 7 2022

eklepilkina removed a reviewer for D139553: [llvm-objdump][RISCV] Use new common method to parse ARCH RISCV attribute: Hsiang-Kai.
Dec 7 2022, 11:32 PM · Restricted Project, Restricted Project
eklepilkina added reviewers for D139553: [llvm-objdump][RISCV] Use new common method to parse ARCH RISCV attribute: HsiangKai, Hsiang-Kai.
Dec 7 2022, 11:32 PM · Restricted Project, Restricted Project
eklepilkina added a comment to D139553: [llvm-objdump][RISCV] Use new common method to parse ARCH RISCV attribute.

I haven't found any reasons written in comments or docs why llvm-objdump couldn't take the attributes from elf file and decode all instructions without extra flags. Could you please have a look is this change can be valid?

Dec 7 2022, 9:38 AM · Restricted Project, Restricted Project
eklepilkina removed a reviewer for D139553: [llvm-objdump][RISCV] Use new common method to parse ARCH RISCV attribute: Hsiang-Kai.
Dec 7 2022, 9:35 AM · Restricted Project, Restricted Project
eklepilkina added a reviewer for D139553: [llvm-objdump][RISCV] Use new common method to parse ARCH RISCV attribute: Hsiang-Kai.
Dec 7 2022, 9:35 AM · Restricted Project, Restricted Project
eklepilkina requested review of D139553: [llvm-objdump][RISCV] Use new common method to parse ARCH RISCV attribute.
Dec 7 2022, 9:32 AM · Restricted Project, Restricted Project

Nov 22 2022

eklepilkina updated the diff for D136344: [ELF][RISCV] Merge `.riscv.attributes` sections.
  • Review fixes
Nov 22 2022, 11:26 PM · Restricted Project, Restricted Project

Nov 21 2022

eklepilkina updated the diff for D136344: [ELF][RISCV] Merge `.riscv.attributes` sections.
  • Review fixes
Nov 21 2022, 11:59 PM · Restricted Project, Restricted Project
eklepilkina retitled D136344: [ELF][RISCV] Merge `.riscv.attributes` sections from [ELF][RISCV] Merge `riscv.attributes` sections from all input files to [ELF][RISCV] Merge `.riscv.attributes` sections.
Nov 21 2022, 5:47 AM · Restricted Project, Restricted Project
eklepilkina added inline comments to D136344: [ELF][RISCV] Merge `.riscv.attributes` sections.
Nov 21 2022, 5:46 AM · Restricted Project, Restricted Project
eklepilkina updated the diff for D136344: [ELF][RISCV] Merge `.riscv.attributes` sections.
  • Review fixes
  • Added test for lto case
Nov 21 2022, 5:46 AM · Restricted Project, Restricted Project

Nov 17 2022

eklepilkina added a comment to D136344: [ELF][RISCV] Merge `.riscv.attributes` sections.

Gently ping

Nov 17 2022, 12:10 AM · Restricted Project, Restricted Project

Nov 7 2022

eklepilkina added a comment to D136344: [ELF][RISCV] Merge `.riscv.attributes` sections.

@MaskRay thank you for review. I fixed all comments, could you have a look again?

Nov 7 2022, 12:07 AM · Restricted Project, Restricted Project
eklepilkina updated the diff for D136344: [ELF][RISCV] Merge `.riscv.attributes` sections.
  • Review fixes
Nov 7 2022, 12:05 AM · Restricted Project, Restricted Project

Nov 6 2022

eklepilkina updated the summary of D136344: [ELF][RISCV] Merge `.riscv.attributes` sections.
Nov 6 2022, 11:35 PM · Restricted Project, Restricted Project
eklepilkina updated the summary of D136344: [ELF][RISCV] Merge `.riscv.attributes` sections.
Nov 6 2022, 11:35 PM · Restricted Project, Restricted Project
eklepilkina updated the summary of D136344: [ELF][RISCV] Merge `.riscv.attributes` sections.
Nov 6 2022, 11:34 PM · Restricted Project, Restricted Project

Oct 31 2022

eklepilkina added inline comments to D136344: [ELF][RISCV] Merge `.riscv.attributes` sections.
Oct 31 2022, 8:13 AM · Restricted Project, Restricted Project
eklepilkina updated the diff for D136344: [ELF][RISCV] Merge `.riscv.attributes` sections.
  • Fix merge rules for attributes based on documentation
Oct 31 2022, 8:11 AM · Restricted Project, Restricted Project
eklepilkina added a comment to D136344: [ELF][RISCV] Merge `.riscv.attributes` sections.

Gently ping

Oct 31 2022, 4:59 AM · Restricted Project, Restricted Project

Oct 20 2022

eklepilkina updated the summary of D136344: [ELF][RISCV] Merge `.riscv.attributes` sections.
Oct 20 2022, 5:53 AM · Restricted Project, Restricted Project
eklepilkina requested review of D136344: [ELF][RISCV] Merge `.riscv.attributes` sections.
Oct 20 2022, 5:50 AM · Restricted Project, Restricted Project

Oct 17 2022

eklepilkina added a comment to D127726: [InstCombiner] Add option to replace PHI of GEPs with GEP with PHI as index.

Gently ping

Oct 17 2022, 12:25 AM · Restricted Project, Restricted Project
eklepilkina added a comment to D127858: [RISCV] Added flag to enable SeparateConstOffsetFromGEPPass for RISC-V target.

Gently ping

Oct 17 2022, 12:24 AM · Restricted Project, Restricted Project
eklepilkina added a comment to D130769: [RISCV] Combine and remove redundant ADD/SUB instructions.

Gently ping

Oct 17 2022, 12:24 AM · Restricted Project, Restricted Project

Sep 20 2022

eklepilkina updated the summary of D127858: [RISCV] Added flag to enable SeparateConstOffsetFromGEPPass for RISC-V target.
Sep 20 2022, 12:19 AM · Restricted Project, Restricted Project
eklepilkina retitled D127858: [RISCV] Added flag to enable SeparateConstOffsetFromGEPPass for RISC-V target from [RISCV] Turn on SeparateConstOffsetFromGEPPass for RISC-V target to [RISCV] Added flag to enable SeparateConstOffsetFromGEPPass for RISC-V target.
Sep 20 2022, 12:18 AM · Restricted Project, Restricted Project

Sep 19 2022

eklepilkina added a comment to D127726: [InstCombiner] Add option to replace PHI of GEPs with GEP with PHI as index.

Gently ping

Sep 19 2022, 8:30 AM · Restricted Project, Restricted Project
eklepilkina added a comment to D130769: [RISCV] Combine and remove redundant ADD/SUB instructions.

Gently ping

Sep 19 2022, 8:29 AM · Restricted Project, Restricted Project
eklepilkina added a comment to D127858: [RISCV] Added flag to enable SeparateConstOffsetFromGEPPass for RISC-V target.

Gently ping

Sep 19 2022, 8:29 AM · Restricted Project, Restricted Project

Aug 29 2022

eklepilkina retitled D131572: [SeparateConstOffsetFromGEP] Added statistic and small refactoring from [NFC][SeparateConstOffsetFromGEP] Small refactoring and reformatting to [SeparateConstOffsetFromGEP] Added statistic and small refactoring.
Aug 29 2022, 8:40 AM · Restricted Project, Restricted Project
eklepilkina updated the diff for D131572: [SeparateConstOffsetFromGEP] Added statistic and small refactoring.
  • Fix format
Aug 29 2022, 8:39 AM · Restricted Project, Restricted Project
eklepilkina added a comment to D127858: [RISCV] Added flag to enable SeparateConstOffsetFromGEPPass for RISC-V target.

Please, could someone has a look? Now I just want to add flag to use the current implementation of pass.

Aug 29 2022, 5:25 AM · Restricted Project, Restricted Project
eklepilkina updated the diff for D127858: [RISCV] Added flag to enable SeparateConstOffsetFromGEPPass for RISC-V target.
Aug 29 2022, 5:24 AM · Restricted Project, Restricted Project
eklepilkina abandoned D127727: [SeparateConstOffsetFromGEPPass] Added optional modification strategy.

Sorry for delay. Looked more on different benchmarks from test-suite during searching a good test case. There are such cases. But a deep exploration shows that SeparateConstOffsetFromGEP pass isn't the main reason, it produces better IR, but in some cases later passes can make it worse and cause worse asssembly code. So hacks I have made in the current pass as workarounds for these particular cases don't seem to be the proper decision. As far as this pass isn't the main reason of regressions we got, I decided to abandon this review.

Aug 29 2022, 5:17 AM · Restricted Project, Restricted Project
eklepilkina added a comment to D131572: [SeparateConstOffsetFromGEP] Added statistic and small refactoring.

Hello! Decided to change this reviews stack. Could you please have a look?

Aug 29 2022, 5:07 AM · Restricted Project, Restricted Project
eklepilkina updated the diff for D131572: [SeparateConstOffsetFromGEP] Added statistic and small refactoring.

Fix format

Aug 29 2022, 5:05 AM · Restricted Project, Restricted Project
eklepilkina updated the diff for D131572: [SeparateConstOffsetFromGEP] Added statistic and small refactoring.

Update

Aug 29 2022, 5:03 AM · Restricted Project, Restricted Project