This is an archive of the discontinued LLVM Phabricator instance.

[compiler-rt] Disable a test failing on windows.
ClosedPublic

Authored by etienneb on Jul 11 2016, 10:33 PM.

Details

Summary

The unittest is not working on windows. The "regexp.h" is not available and
gtest-port won't support regexp with operator '|'.

The test wasn't failing on 32-bits because of this check:

if (SANITIZER_WORDSIZE != 64 || ASAN_AVOID_EXPENSIVE_TESTS) return;
[ RUN      ] AddressSanitizer.HugeMallocTest
C:/src/llvm/llvm/utils/unittest/googletest\src/gtest-port.cc(272): error: Failed
Syntax error at index 30 in simple regular expression "is located 1 bytes to the left|AddressSanitizer failed to allocate": '|' is unsupported.
C:/src/llvm/llvm/projects/compiler-rt/lib/asan/tests/asan_test.cc(308): error: Death test: Ident((char*)malloc(n_megs << 20))[-1] = 0
    Result: died but not with expected error.
  Expected: is located 1 bytes to the left|AddressSanitizer failed to allocate

See gtest-port.h:

  #elif GTEST_OS_WINDOWS

// <regex.h> is not available on Windows.  Use our own simple regex
// implementation instead.
# define GTEST_USES_SIMPLE_RE 1

Diff Detail

Event Timeline

etienneb updated this revision to Diff 63638.Jul 11 2016, 10:33 PM
etienneb retitled this revision from to [compiler-rt] Disable a test failing on windows..
etienneb updated this object.
etienneb added a reviewer: rnk.
rnk accepted this revision.Jul 12 2016, 8:29 AM
rnk edited edge metadata.

lgtm

This revision is now accepted and ready to land.Jul 12 2016, 8:29 AM
etienneb closed this revision.Jul 12 2016, 8:40 AM