[asan] Fix unittest Asan-x86_64-inline-Test crashing on Windows64

[wang0109]

Summary

[asan] Fix unittest Asan-x86_64-inline-Test crashing on Windows64

REAL(memcpy) was used in several places in Asan, while REAL(memmove) was not used.
This CL chooses to patch memcpy() first, solving the crash for unittest.

The crash looks like this:

projects\compiler-rt\lib\asan\tests\default\Asan-x86_64-inline-Test.exe
=================================================================
==22680==ERROR: AddressSanitizer: access-violation on unknown address 0x000000000000 (pc 0x000000000000 bp 0x0029d555f590 sp 0x0029d555f438 T0)
==22680==Hint: pc points to the zero page.

AddressSanitizer can not provide additional info.
 SUMMARY: AddressSanitizer: access-violation (<unknown module>)
==22680==ABORTING

[etienneb]

lib/asan/asan_interceptors.cc

731–733

In this case, I won't put the comment.
All interception may fail and leave a null pointer.

Instead, I think we should add CHECK(REAL(func)) for the function we are calling.
Do a grep over the code and add them at the end of the function.

[wang0109]

• update diff: assert success of intercepting memcopy()

[etienneb]

List of functions with REAL(func) inside the code:

(__cxa_atexit)
(__cxa_throw)
(_except_handler3)
(_except_handler4)
(_longjmp)
(atoi)
(atol)
(atoll)
(bsd_signal)
(calloc)
(CreateThread)
(dispatch_after)
(dispatch_after_f)
(dispatch_async)
(dispatch_group_async)
(dispatch_group_async_f)
(dispatch_source_set_cancel_handler)
(dispatch_source_set_event_handler)
(dispatch_x_f)
(fork)
(func)
(longjmp)
(malloc)
(memcpy)
(memset)
(name)
(NtWaitForWorkViaWorkerFactory)
(pthread_attr_getdetachstate)
(pthread_create)
(RaiseException)
(sigaction)
(siglongjmp)
(signal)
(strcat)
(strcpy)
(strlen)
(strncat)
(strncpy)
(strnlen)
(strtol)
(strtoll)
(swapcontext)
(wcslen)

[wang0109]

• update diff: rewrite comment

[etienneb]

what about this instead?

*(::__interception::uptr **)&REAL(memmove) =
      (::__interception::uptr *)&REAL(memcpy);

[rnk]

lgtm

[etienneb]

lib/asan/asan_interceptors.cc

735

Hey, this doesn't compile.

memcopy -> memcpy

[wang0109]

• update diff: fix typo

lib/asan/asan_interceptors.cc

 namespace __asan {
 void InitializeAsanInterceptors() {
   static bool was_called_once;
   CHECK(was_called_once == false);
   was_called_once = true;
   InitializeCommonInterceptors();
 
   // Intercept mem* functions.
-  ASAN_INTERCEPT_FUNC(memmove);
+  ASAN_INTERCEPT_FUNC(memcpy);
   ASAN_INTERCEPT_FUNC(memset);
   if (PLATFORM_HAS_DIFFERENT_MEMCPY_AND_MEMMOVE) {
-    ASAN_INTERCEPT_FUNC(memcpy);
+    // FIXME(wwchrome): REAL(memmove) may be nullptr, if the following line is
+    // skipped, due to memcpy and memmove having the same address.
+    ASAN_INTERCEPT_FUNC(memmove);
   }
+  CHECK(REAL(memcopy));
 
   // Intercept str* functions.
   ASAN_INTERCEPT_FUNC(strcat);  // NOLINT
   ASAN_INTERCEPT_FUNC(strcpy);  // NOLINT
   ASAN_INTERCEPT_FUNC(wcslen);
   ASAN_INTERCEPT_FUNC(strncat);
   ASAN_INTERCEPT_FUNC(strncpy);
   ASAN_INTERCEPT_FUNC(strdup);