[clang-rename] extend testset

[omtcyf0]

Summary

This patch introduces few additional tests including one case the tool does not handle yet, which should be fixed in the future.

[omtcyf0]

add XFAIL test with virtual function renaming

[klimek]

Add
// FIXME: <desired behavior to implement>
to tests that do not work yet.

I'd personally not check in the XFAIL tests for now, and just add them when you implement the missing functionality; the problem with XFAIL here is that (due to the offsets involved) they can easily switch into a mode where they fail not because the feature is not implemented, but because the test is incorrect.

[klimek]

test/clang-rename/TemplateTypename.cpp

4

Here, too?

[omtcyf0]

Oops, sorry. Fixed it.

+1 currently unsupported test.

[klimek]

lg

[omtcyf0]

Thanks, Manuel!

Can you please land it?

[vmiklos]

Can you please avoid adding VirtualFunction.cpp? http://reviews.llvm.org/D22237 would add it as well, but without the FIXME. Thanks! :-)

[omtcyf0]

@vmiklos sure thing.

Thanks for noticing!

test/clang-rename/FunctionMacro.cpp

+// RUN: cat %s > %t.cpp
+// RUN: clang-rename -offset=199 -new-name=macro_function %t.cpp -i --
+// RUN: sed 's,//.*,,' %t.cpp | FileCheck %s
+
+#define moo foo // CHECK: #define moo macro_function
+
+int foo() {     // CHECK: int macro_function() {
+  return 42;
+}
+
+void boo(int value) {}
+
+void qoo() {
+  foo();        // CHECK: macro_function();
+  boo(foo());   // CHECK: boo(macro_function());
+  moo();
+  boo(moo());
+}
+
+// Use grep -FUbo 'foo;' <file> to get the correct offset of foo when changing
+// this file.

test/clang-rename/Namespace.cpp

+// RUN: cat %s > %t.cpp
+// RUN: clang-rename -offset=143 -new-name=llvm %t.cpp -i --
+// RUN: sed 's,//.*,,' %t.cpp | FileCheck %s
+
+namespace foo { // CHECK: namespace llvm {
+  int x;
+}
+
+void boo() {
+  foo::x = 42;  // CHECK: llvm::x = 42;
+}
+
+// Use grep -FUbo 'foo;' <file> to get the correct offset of foo when changing
+// this file.

test/clang-rename/TemplateTypename.cpp

+// RUN: cat %s > %t.cpp
+// RUN: clang-rename -offset=152 -new-name=U %t.cpp -i --
+// RUN: sed 's,//.*,,' %t.cpp | FileCheck %s
+// XFAIL: *
+
+template <typename T>             // CHECK: template <typename U>
+T foo(T arg, T& ref, T* ptr) {    // CHECK: U foo(U arg, U& ref, U* ptr) {
+  T value;                        // CHECK: U value;
+  int number = 42;
+  value = (T)number;              // CHECK: value = (U)number;
+  value = static_cast<T>(number); // CHECK: value = static_cast<U>(number);
+  return value;
+}
+
+// Use grep -FUbo 'foo;' <file> to get the correct offset of foo when changing
+// this file.

test/clang-rename/VariableMacro.cpp

+// RUN: cat %s > %t.cpp
+// RUN: clang-rename -offset=208 -new-name=Z %t.cpp -i --
+// RUN: sed 's,//.*,,' %t.cpp | FileCheck %s
+
+#define Y X // CHECK: #define Y Z
+
+void foo(int value) {}
+
+void macro() {
+  int X;    // CHECK: int Z;
+  X = 42;   // CHECK: Z = 42;
+  Y -= 0;
+  foo(X);   // CHECK: foo(Z);
+  foo(Y);
+}
+
+// Use grep -FUbo 'foo;' <file> to get the correct offset of foo when changing
+// this file.

test/clang-rename/VirtualFunction.cpp

+// Currently unsupported test.
+// FIXME: after passing A::foo() to clang-rename the tools should also rename
+// B:foo(), which overrides A::foo().
+
+class A {
+public:
+  virtual void foo();
+};
+
+class B : public A {
+public:
+  void foo();
+};