This is an archive of the discontinued LLVM Phabricator instance.

[sanitizer] Handle null in internal_sigaction_syscall
ClosedPublic

Authored by bruening on Jul 6 2016, 11:39 AM.

Reviewers

Commits

Summary

Adds support for nullptr as the action parameter to
internal_sigaction_syscall().

bruening retitled this revision from to [sanitizer] Handle null in internal_sigaction_syscall.

bruening updated this object.

bruening added a reviewer: aizatsky.

aizatsky edited edge metadata.

This revision is now accepted and ready to land.Jul 6 2016, 11:48 AM

This revision was automatically updated to reflect the committed changes.

Path

Size

lib/

sanitizer_common/

2 lines

Show First 20 Lines • Show All 667 Lines • ▼ Show 20 Lines	#endif
return result;		return result;
}		}

// Invokes sigaction via a raw syscall with a restorer, but does not support		// Invokes sigaction via a raw syscall with a restorer, but does not support
// all platforms yet.		// all platforms yet.
// We disable for Go simply because we have not yet added to buildgo.sh.		// We disable for Go simply because we have not yet added to buildgo.sh.
#if defined(__x86_64__) && !SANITIZER_GO		#if defined(__x86_64__) && !SANITIZER_GO
int internal_sigaction_syscall(int signum, const void act, void oldact) {		int internal_sigaction_syscall(int signum, const void act, void oldact) {
		if (act == nullptr)
		return internal_sigaction_norestorer(signum, act, oldact);
__sanitizer_sigaction u_adjust;		__sanitizer_sigaction u_adjust;
internal_memcpy(&u_adjust, act, sizeof(u_adjust));		internal_memcpy(&u_adjust, act, sizeof(u_adjust));
#if !SANITIZER_ANDROID \|\| !SANITIZER_MIPS32		#if !SANITIZER_ANDROID \|\| !SANITIZER_MIPS32
if (u_adjust.sa_restorer == nullptr) {		if (u_adjust.sa_restorer == nullptr) {
u_adjust.sa_restorer = internal_sigreturn;		u_adjust.sa_restorer = internal_sigreturn;
}		}
#endif		#endif
return internal_sigaction_norestorer(signum, (const void *)&u_adjust,		return internal_sigaction_norestorer(signum, (const void *)&u_adjust,
▲ Show 20 Lines • Show All 698 Lines • Show Last 20 Lines