Page MenuHomePhabricator

bruening (Derek Bruening)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 18 2016, 9:50 AM (190 w, 5 d)

Recent Activity

Jun 25 2017

bruening committed rL306259: [esan] Disable flaky tests for PR33590.
[esan] Disable flaky tests for PR33590
Jun 25 2017, 6:03 PM

Oct 7 2016

bruening accepted D25380: [esan] Fix ESan test failure on Debian Sid bot.
Oct 7 2016, 1:59 PM
bruening added a comment to D25380: [esan] Fix ESan test failure on Debian Sid bot.

Ideally this would be shared with the other sanitizers. We're also not sure why the other sanitizers aren't failing on sid. But this should fix it short-term.

Oct 7 2016, 1:59 PM

Oct 3 2016

bruening accepted D25193: [esan] Fix ESan test failure on Debian Sid bot.
Oct 3 2016, 1:03 PM
bruening requested changes to D25193: [esan] Fix ESan test failure on Debian Sid bot.
Oct 3 2016, 9:50 AM
bruening added a comment to D25193: [esan] Fix ESan test failure on Debian Sid bot.

Handles early allocation from dlsym by allocating memory from a local
static buffer.

Oct 3 2016, 9:23 AM

Sep 26 2016

bruening accepted D24332: [ESan] [MIPS] Fix workingset-signal-posix.cpp on MIPS.
Sep 26 2016, 10:10 AM · Restricted Project
bruening added a comment to D23801: [EfficiencySanitizer] Adds shadow memory parameters for 40-bit virtual memory address..

I assume your ping is to rengolin as his request for changes is still there.

Sep 26 2016, 8:32 AM · Restricted Project

Sep 14 2016

bruening added a reviewer for D23799: [ESan][MIPS] Adds support for MIPS64: zhaoqin.
Sep 14 2016, 12:16 PM · Restricted Project

Sep 8 2016

bruening updated subscribers of D24332: [ESan] [MIPS] Fix workingset-signal-posix.cpp on MIPS.
Sep 8 2016, 1:21 PM · Restricted Project
bruening added inline comments to D24332: [ESan] [MIPS] Fix workingset-signal-posix.cpp on MIPS.
Sep 8 2016, 1:21 PM · Restricted Project
bruening added a comment to D24335: [ESan] [MIPS] Fix tests mmap-shadow-conflict.c and struct-simple.cpp on MIPS.

Depends on https://reviews.llvm.org/D24334 where the s/#/_/ is under discussion

Sep 8 2016, 1:03 PM · Restricted Project
bruening added a reviewer for D24335: [ESan] [MIPS] Fix tests mmap-shadow-conflict.c and struct-simple.cpp on MIPS: zhaoqin.
Sep 8 2016, 1:01 PM · Restricted Project
bruening updated subscribers of D23801: [EfficiencySanitizer] Adds shadow memory parameters for 40-bit virtual memory address..
Sep 8 2016, 1:00 PM · Restricted Project
bruening accepted D24350: Revert "[ESan][MIPS] Adds support for MIPS64".

Just a pure revert, right?

Sep 8 2016, 9:15 AM
bruening added a reviewer for D24334: [EfficiencySanitizer] Using '$' instead of '#' for struct counter name: zhaoqin.
Sep 8 2016, 8:16 AM · Restricted Project

Aug 31 2016

bruening accepted D23799: [ESan][MIPS] Adds support for MIPS64.
Aug 31 2016, 10:25 PM · Restricted Project

Aug 29 2016

bruening added inline comments to D23799: [ESan][MIPS] Adds support for MIPS64.
Aug 29 2016, 11:42 AM · Restricted Project
bruening accepted D23800: [EfficiencySanitizer] [MIPS64] Enables esan clang driver options for MIPS64.
Aug 29 2016, 11:36 AM · Restricted Project

Aug 26 2016

bruening added inline comments to D23799: [ESan][MIPS] Adds support for MIPS64.
Aug 26 2016, 4:05 PM · Restricted Project
bruening accepted D23801: [EfficiencySanitizer] Adds shadow memory parameters for 40-bit virtual memory address..
Aug 26 2016, 10:58 AM · Restricted Project

Aug 25 2016

bruening added inline comments to D23801: [EfficiencySanitizer] Adds shadow memory parameters for 40-bit virtual memory address..
Aug 25 2016, 8:44 PM · Restricted Project
bruening added inline comments to D23799: [ESan][MIPS] Adds support for MIPS64.
Aug 25 2016, 8:41 PM · Restricted Project
bruening added a comment to D23800: [EfficiencySanitizer] [MIPS64] Enables esan clang driver options for MIPS64.

Please add a mips target test to at least test/Driver/esan.c.

Aug 25 2016, 5:55 PM · Restricted Project

Aug 8 2016

bruening committed rL278027: [esan] Add iterator to esan's generic hashtable.
[esan] Add iterator to esan's generic hashtable
Aug 8 2016, 10:45 AM
bruening closed D22682: [esan] Add iterator to esan's generic hashtable by committing rL278027: [esan] Add iterator to esan's generic hashtable.
Aug 8 2016, 10:45 AM
bruening committed rL278024: [esan] Add generic resizing hashtable.
[esan] Add generic resizing hashtable
Aug 8 2016, 10:33 AM
bruening closed D22681: [esan] Add generic resizing hashtable by committing rL278024: [esan] Add generic resizing hashtable.
Aug 8 2016, 10:33 AM

Aug 2 2016

bruening updated the diff for D22681: [esan] Add generic resizing hashtable.

Makes the table more like a classic C++ container:
+ Moves the hash function pointer to be a functor template parameter
+ Adds a functor template parameter for the comparision function
+ Moves ExternalLock to be a template paramter to eliminate conditional branches
+ Eliminates the default pointer deref
+ Removes the payload-freeing function pointer in favor of calling the destructor

Aug 2 2016, 12:17 PM
bruening added inline comments to D22681: [esan] Add generic resizing hashtable.
Aug 2 2016, 12:15 PM

Aug 1 2016

bruening updated the diff for D22682: [esan] Add iterator to esan's generic hashtable.

Address reviewer requests: more tests, comment on copying.

Aug 1 2016, 1:11 PM
bruening added inline comments to D22682: [esan] Add iterator to esan's generic hashtable.
Aug 1 2016, 1:10 PM
bruening added inline comments to D22681: [esan] Add generic resizing hashtable.
Aug 1 2016, 12:22 PM

Jul 27 2016

bruening added a reviewer for D22682: [esan] Add iterator to esan's generic hashtable: zhaoqin.
Jul 27 2016, 6:37 AM
bruening added a reviewer for D22681: [esan] Add generic resizing hashtable: zhaoqin.
Jul 27 2016, 6:36 AM

Jul 22 2016

bruening retitled D22682: [esan] Add iterator to esan's generic hashtable from to [esan] Add iterator to esan's generic hashtable.
Jul 22 2016, 8:20 AM
bruening retitled D22681: [esan] Add generic resizing hashtable from to [esan] Add generic resizing hashtable.
Jul 22 2016, 8:19 AM

Jul 18 2016

bruening committed rL275948: [esan|wset] Fix flaky sampling tests.
[esan|wset] Fix flaky sampling tests
Jul 18 2016, 10:14 PM
bruening committed rL275946: [esan] Fix sideline thread flaky assert.
[esan] Fix sideline thread flaky assert
Jul 18 2016, 10:11 PM

Jul 14 2016

bruening added inline comments to D21753: Comprehensive Static Instrumentation (2/2): Clang flag.
Jul 14 2016, 5:02 PM · Restricted Project

Jul 8 2016

bruening committed rL274964: [esan] Add __esan_report for mid-run data.
[esan] Add __esan_report for mid-run data
Jul 8 2016, 9:20 PM
bruening closed D22098: [esan] Add __esan_report for mid-run data by committing rL274964: [esan] Add __esan_report for mid-run data.
Jul 8 2016, 9:20 PM
bruening added a comment to D22098: [esan] Add __esan_report for mid-run data.
Jul 8 2016, 7:25 PM
bruening added inline comments to D22098: [esan] Add __esan_report for mid-run data.
Jul 8 2016, 11:53 AM
bruening added inline comments to D22098: [esan] Add __esan_report for mid-run data.
Jul 8 2016, 9:09 AM

Jul 7 2016

bruening retitled D22098: [esan] Add __esan_report for mid-run data from to [esan] Add __esan_report for mid-run data.
Jul 7 2016, 9:58 AM
bruening abandoned D20746: [sanitizer] Add iterator to AddrHashMap.

AddrHashMap has significant limitations that make it unsuitable for most of our use cases for hashtables and we're going to need to add a separate, more general-purpose table: the data being read-only after creation, and most importantly, the fixed-size table that cannot resize and adapt to the size of the app, are blockers for us. Abandoning this CL.

Jul 7 2016, 9:02 AM

Jul 6 2016

bruening added inline comments to D21753: Comprehensive Static Instrumentation (2/2): Clang flag.
Jul 6 2016, 8:28 PM · Restricted Project
bruening committed rL274672: [esan|wset] Ensure SIGSEGV is not blocked.
[esan|wset] Ensure SIGSEGV is not blocked
Jul 6 2016, 2:12 PM
bruening closed D22063: [esan|wset] Ensure SIGSEGV is not blocked by committing rL274672: [esan|wset] Ensure SIGSEGV is not blocked.
Jul 6 2016, 2:11 PM
bruening committed rL274669: [esan|wset] Further reduce flakiness of sampling test.
[esan|wset] Further reduce flakiness of sampling test
Jul 6 2016, 1:35 PM
bruening committed rL274666: [esan|wset] Fix incorrect memory size assert.
[esan|wset] Fix incorrect memory size assert
Jul 6 2016, 1:21 PM
bruening closed D22062: [esan|wset] Fix incorrect memory size assert by committing rL274666: [esan|wset] Fix incorrect memory size assert.
Jul 6 2016, 1:21 PM
bruening committed rL274665: [sanitizer] Handle null in internal_sigaction_syscall.
[sanitizer] Handle null in internal_sigaction_syscall
Jul 6 2016, 1:21 PM
bruening closed D22061: [sanitizer] Handle null in internal_sigaction_syscall by committing rL274665: [sanitizer] Handle null in internal_sigaction_syscall.
Jul 6 2016, 1:20 PM
bruening retitled D22063: [esan|wset] Ensure SIGSEGV is not blocked from to [esan|wset] Ensure SIGSEGV is not blocked.
Jul 6 2016, 11:48 AM
bruening retitled D22062: [esan|wset] Fix incorrect memory size assert from to [esan|wset] Fix incorrect memory size assert.
Jul 6 2016, 11:45 AM
bruening retitled D22061: [sanitizer] Handle null in internal_sigaction_syscall from to [sanitizer] Handle null in internal_sigaction_syscall.
Jul 6 2016, 11:39 AM

Jun 30 2016

bruening added inline comments to D21752: Comprehensive Static Instrumentation (1/2): LLVM pass.
Jun 30 2016, 10:57 AM · Restricted Project
bruening added inline comments to D21753: Comprehensive Static Instrumentation (2/2): Clang flag.
Jun 30 2016, 9:55 AM · Restricted Project

Jun 15 2016

bruening committed rL272870: [esan] Use internal_mmap during initialization.
[esan] Use internal_mmap during initialization
Jun 15 2016, 8:26 PM
bruening accepted D21351: [esan|cfrag] Minor cfrag report adjustment.
Jun 15 2016, 8:38 AM

Jun 14 2016

bruening added inline comments to D21351: [esan|cfrag] Minor cfrag report adjustment.
Jun 14 2016, 8:27 PM
bruening committed rL272676: [sanitizer][esan] Add internal_sigaction_syscall.
[sanitizer][esan] Add internal_sigaction_syscall
Jun 14 2016, 8:22 AM

Jun 13 2016

bruening committed rL272591: [sanitizer][esan] Add internal_sigaction_syscall.
[sanitizer][esan] Add internal_sigaction_syscall
Jun 13 2016, 2:56 PM
bruening committed rL272557: Revert "[sanitizer][esan] Add internal_sigaction_syscall".
Revert "[sanitizer][esan] Add internal_sigaction_syscall"
Jun 13 2016, 9:23 AM
bruening committed rL272553: [sanitizer][esan] Add internal_sigaction_syscall.
[sanitizer][esan] Add internal_sigaction_syscall
Jun 13 2016, 8:49 AM
bruening closed D21083: [sanitizer][esan] Add internal_sigaction_syscall by committing rL272553: [sanitizer][esan] Add internal_sigaction_syscall.
Jun 13 2016, 8:49 AM

Jun 10 2016

bruening added a comment to D21083: [sanitizer][esan] Add internal_sigaction_syscall.

PTAL

Jun 10 2016, 2:51 PM
bruening added a comment to D21242: [esan|cfrag] Handle complex GEP instr in the cfrag tool.

The commit message has spelling and grammar errors.

Jun 10 2016, 2:03 PM
bruening updated the diff for D21083: [sanitizer][esan] Add internal_sigaction_syscall.

Shares code between the two sigaction routines.

Jun 10 2016, 8:52 AM

Jun 8 2016

bruening committed rL272175: [esan|wset] Reduce flakiness in samples test.
[esan|wset] Reduce flakiness in samples test
Jun 8 2016, 10:42 AM
bruening added inline comments to D21083: [sanitizer][esan] Add internal_sigaction_syscall.
Jun 8 2016, 10:31 AM
bruening added inline comments to D21079: [esan|cfrag] Disable load/store instrumentation for cfrag.
Jun 8 2016, 10:29 AM
bruening updated the diff for D21083: [sanitizer][esan] Add internal_sigaction_syscall.

Add a test that emulates an instrumented allocator.

Jun 8 2016, 10:22 AM

Jun 7 2016

bruening committed rL272076: [esan] Intercept calloc to avoid deadlocks with tcmalloc.
[esan] Intercept calloc to avoid deadlocks with tcmalloc
Jun 7 2016, 5:07 PM
bruening closed D21086: [esan] Intercept calloc to avoid deadlocks with tcmalloc by committing rL272076: [esan] Intercept calloc to avoid deadlocks with tcmalloc.
Jun 7 2016, 5:07 PM
bruening added a comment to D21083: [sanitizer][esan] Add internal_sigaction_syscall.

I feel that this definitely needs a test. Can you craft something up?

Jun 7 2016, 3:25 PM
bruening updated the diff for D21086: [esan] Intercept calloc to avoid deadlocks with tcmalloc.

Clear the used flag, and comment on races.

Jun 7 2016, 3:23 PM
bruening added inline comments to D21086: [esan] Intercept calloc to avoid deadlocks with tcmalloc.
Jun 7 2016, 3:22 PM
bruening retitled D21086: [esan] Intercept calloc to avoid deadlocks with tcmalloc from to [esan] Intercept calloc to avoid deadlocks with tcmalloc.
Jun 7 2016, 10:39 AM
bruening retitled D21083: [sanitizer][esan] Add internal_sigaction_syscall from to [sanitizer][esan] Add internal_sigaction_syscall.
Jun 7 2016, 10:01 AM

Jun 3 2016

bruening committed rL271744: [esan] Initialize runtime during early interceptors.
[esan] Initialize runtime during early interceptors
Jun 3 2016, 3:36 PM
bruening closed D20976: [esan] Initialize runtime during early interceptors by committing rL271744: [esan] Initialize runtime during early interceptors.
Jun 3 2016, 3:36 PM
bruening committed rL271743: [esan|wset] Optionally assume intra-cache-line accesses.
[esan|wset] Optionally assume intra-cache-line accesses
Jun 3 2016, 3:36 PM
bruening closed D20978: [esan|wset] Optionally assume intra-cache-line accesses by committing rL271743: [esan|wset] Optionally assume intra-cache-line accesses.
Jun 3 2016, 3:36 PM
bruening updated the diff for D20978: [esan|wset] Optionally assume intra-cache-line accesses.

Add stat on the number of assumptions.

Jun 3 2016, 2:05 PM
bruening updated the diff for D20976: [esan] Initialize runtime during early interceptors.

Eliminate one branch on the interceptor entry common path.

Jun 3 2016, 2:01 PM
bruening added a comment to D20976: [esan] Initialize runtime during early interceptors.
Jun 3 2016, 2:01 PM
bruening committed rL271715: [esan] Specify which tool via a global variable.
[esan] Specify which tool via a global variable
Jun 3 2016, 12:47 PM
bruening closed D20973: [esan] Specify which tool via a global variable by committing rL271715: [esan] Specify which tool via a global variable.
Jun 3 2016, 12:47 PM
bruening committed rL271714: [esan] Specify which tool via a global variable.
[esan] Specify which tool via a global variable
Jun 3 2016, 12:46 PM
bruening closed D20974: [esan] Specify which tool via a global variable by committing rL271714: [esan] Specify which tool via a global variable.
Jun 3 2016, 12:46 PM
bruening retitled D20978: [esan|wset] Optionally assume intra-cache-line accesses from to [esan|wset] Optionally assume intra-cache-line accesses.
Jun 3 2016, 11:42 AM
bruening retitled D20976: [esan] Initialize runtime during early interceptors from to [esan] Initialize runtime during early interceptors.
Jun 3 2016, 11:33 AM
bruening retitled D20974: [esan] Specify which tool via a global variable from to [esan] Specify which tool via a global variable.
Jun 3 2016, 11:24 AM
bruening retitled D20973: [esan] Specify which tool via a global variable from to [esan] Specify which tool via a global variable.
Jun 3 2016, 11:24 AM
bruening committed rL271691: [esan] Eliminate flakiness in large-stack test.
[esan] Eliminate flakiness in large-stack test
Jun 3 2016, 10:24 AM
bruening committed rL271683: [esan|wset] Add 8-level working set snapshot accumulation.
[esan|wset] Add 8-level working set snapshot accumulation
Jun 3 2016, 9:34 AM
bruening closed D20833: [esan|wset] Add 8-level working set snapshot accumulation by committing rL271683: [esan|wset] Add 8-level working set snapshot accumulation.
Jun 3 2016, 9:34 AM