Added emitting metadata to elf for runtime.
Runtime requires certain information (metadata) about kernels to be able to execute and query them. Such information is emitted to an elf section as a key-value pair stream.
Paths
| Differential D21849
[AMDGPU] Add metadata for runtime ClosedPublic Authored by yaxunl on Jun 29 2016, 11:13 AM.
Details Summary Added emitting metadata to elf for runtime. Runtime requires certain information (metadata) about kernels to be able to execute and query them. Such information is emitted to an elf section as a key-value pair stream.
Diff Detail
Event Timelineyaxunl updated this object. Comment Actions Needs more tests. I would like the full set of types to be tested, particularly weird ones like 3-vectors. Other non-OpenCL types like i1 or a random other bitwidth should also be tested. A few tests that use multiple arguments also would be useful
yaxunl edited edge metadata. yaxunl marked 14 inline comments as done. Comment ActionsRevised as Matt suggested. Comment Actions
I added more tests. bool is not allowed as kernel argument, so I did not add test for bool.
yaxunl retitled this revision from [AMDGPU] Add metadata for OpenCL runtime to [AMDGPU] Add metadata for runtime.Jul 13 2016, 11:23 AM yaxunl updated this object. nhaustov added inline comments.
This revision now requires changes to proceed.Jul 14 2016, 5:58 AM
yaxunl edited edge metadata. yaxunl marked an inline comment as done. Comment ActionsRevised by Nikolay's comments. yaxunl edited edge metadata. Comment ActionsRemoved unused includes and fixed typos in AMDGPURuntimeMetadata.h
yaxunl added inline comments.
This revision is now accepted and ready to land.Jul 15 2016, 3:27 AM Closed by commit rL275566: [AMDGPU] Add metadata for runtime (authored by yaxunl). · Explain WhyJul 15 2016, 8:05 AM This revision was automatically updated to reflect the committed changes. Comment Actions The patch introduced this bug: This revision is now accepted and ready to land.Jul 15 2016, 12:22 PM
Revision Contents
Diff 64142 llvm/trunk/lib/Target/AMDGPU/AMDGPUAsmPrinter.h
llvm/trunk/lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp
llvm/trunk/lib/Target/AMDGPU/AMDGPURuntimeMetadata.h
llvm/trunk/test/CodeGen/AMDGPU/runtime-metadata.ll
|