This is an archive of the discontinued LLVM Phabricator instance.

Differential D21813

ARM: Fix ARMSubtarget for WOA
ClosedPublic

Authored by martell on Jun 28 2016, 1:14 PM.

Details

Reviewers
compnerd
rnk
Commits
rG346a5fdc9bc0: Support: WOA64 and WOA Signals
rL310001: Support: WOA64 and WOA Signals
Summary

Building on http://reviews.llvm.org/rL273682
This will enable lli for WOA64 and WOA hosts

Diff Detail

Repository
rL LLVM

Event Timeline

martell updated this revision to Diff 62129.Jun 28 2016, 1:14 PM
martell retitled this revision from to ARM: Fix ARMSubtarget for WOA.
martell updated this object.
martell added a reviewer: compnerd.
martell set the repository for this revision to rL LLVM.
martell added a subscriber: llvm-commits.
Herald added subscribers: rengolin, aemerson. · View Herald TranscriptJun 28 2016, 1:14 PM
martell updated this revision to Diff 62135.Jun 28 2016, 1:46 PM
martell removed rL LLVM as the repository for this revision.
rengolin added a comment.Jun 28 2016, 2:22 PM

Hi,

Have you run all the tests on Windows (check-all)?

cheers,
--renato

lib/Support/Windows/Signals.inc
535 ↗(On Diff #62135)

Shouldn't this be Fp?

martell updated this revision to Diff 62145.Jun 28 2016, 3:47 PM
martell added a comment.Jun 28 2016, 3:49 PM
In D21813#469255, @rengolin wrote:

Have you run all the tests on Windows (check-all)?

No but I will do.
More changes need to go into Signals.inc to properly print everything out as was intended on ARM.
I just submitted the patch initially to get feedback to see if the change was accurate

lib/Support/Windows/Signals.inc
535 ↗(On Diff #62135)

Yes it should

rengolin added a comment.Jun 28 2016, 3:51 PM

Right, @compnerd knows better about WoA, though.

Also, when you do a diff for Phab, please use "diff -U999" so that we can see the context around the changes. Don't worry, Phab won't show a huge file. :)

cheers,
--renato

compnerd added inline comments.Jun 28 2016, 7:05 PM
lib/Target/ARM/ARMSubtarget.cpp
216

Windows ARM NT is a pure thumb-2 environment. We really should not be generating ARM code. I dont think that this should be changed.

• my123 added a subscriber: • my123.Jun 29 2016, 5:11 AM

It should be changed, as Thumb-2 code is generated after this. With NoARM=true, no JIT code is generated at all

if you didn't see my NoARM comment.

Thumb-2 code is generated anyway, or at least code that fully runs on both 8.0 and 8.1, Fibonnaci is stable even with high test values, which even means that __chkstk works fine.

lib/Target/ARM/ARMSubtarget.cpp
216

It should be changed, as Thumb-2 code is generated after this. With NoARM=true, no JIT code is generated at all

• my123 added a comment.Jun 29 2016, 6:12 AM

Note that I'm defining the target as arm-pc-win32

martell updated this revision to Diff 99711.May 21 2017, 7:12 PM
martell edited the summary of this revision. (Show Details)
martell set the repository for this revision to rL LLVM.

updated to support woa64 and falback to unknown instead of x86 when unknown

martell added a comment.May 21 2017, 7:14 PM

leaving the arm subtarget code out until I actually get a device to test this on.
Should be good to merge.

martell added a reviewer: rnk.May 28 2017, 5:47 PM

@rnk can you review this if you get a chance during the week.
I think compnerd is tied down and I don't want this to rot again :)

martell added a comment.Aug 3 2017, 1:22 PM

ping

rnk accepted this revision.Aug 3 2017, 1:47 PM

lgtm, sorry I declared email bankruptcy at some point.

This revision is now accepted and ready to land.Aug 3 2017, 1:47 PM
martell added a comment.Aug 3 2017, 3:30 PM

Thanks Reid :)

Closed by commit rL310001: Support: WOA64 and WOA Signals (authored by martell). · Explain WhyAug 3 2017, 4:13 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lib/
Target/
ARM/
4 lines

Diff 62129

lib/Target/ARM/ARMSubtarget.cpp

Context not available.
// Initialize scheduling itinerary for the specified CPU. // Initialize scheduling itinerary for the specified CPU.
InstrItins = getInstrItineraryForCPU(CPUString); InstrItins = getInstrItineraryForCPU(CPUString);
// FIXME: this is invalid for WindowsCE
if (isTargetWindows())
NoARM = true;
compnerdUnsubmitted
Not Done
ReplyInline Actions

Windows ARM NT is a pure thumb-2 environment. We really should not be generating ARM code. I dont think that this should be changed.

compnerd: Windows ARM NT is a pure thumb-2 environment. We really should not be generating ARM code. I…
my123Unsubmitted
Not Done
ReplyInline Actions

It should be changed, as Thumb-2 code is generated after this. With NoARM=true, no JIT code is generated at all

my123: It should be changed, as Thumb-2 code is generated after this. With NoARM=true, no JIT code is…
if (isAAPCS_ABI()) if (isAAPCS_ABI())
stackAlignment = 8; stackAlignment = 8;
if (isTargetNaCl() || isAAPCS16_ABI()) if (isTargetNaCl() || isAAPCS16_ABI())
Context not available.