Page MenuHomePhabricator

Allow unaligned byte/word selection watchpoints for arm- linux/android targets.
ClosedPublic

Authored by omjavaid on Jun 19 2016, 9:50 PM.

Details

Summary

We recently committed a patch for AArch64 targets that allows us to watch any byte address individually in a 8 byte aligned region.

This patch implements the same for arm targets with region being watched is a 4 byte region.

We cannot watch 8 consecutive bytes using a single watchpoint resource on Arm targets so maximum we can do is 4 bytes.

As a results TestWatchpointSize tests pass on arm targets which were previously failing.

Diff Detail

Repository
rL LLVM

Event Timeline

omjavaid updated this revision to Diff 61234.Jun 19 2016, 9:50 PM
omjavaid retitled this revision from to Allow unaligned byte/word selection watchpoints for arm- linux/android targets..
omjavaid updated this object.
omjavaid added reviewers: labath, clayborg.
omjavaid added a subscriber: lldb-commits.
tberghammer accepted this revision.Jun 20 2016, 9:56 AM
tberghammer added a reviewer: tberghammer.

Looks good

This revision is now accepted and ready to land.Jun 20 2016, 9:56 AM
clayborg accepted this revision.Jun 20 2016, 3:44 PM
clayborg edited edge metadata.
This revision was automatically updated to reflect the committed changes.