This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] Enable absolute expression initializer for amd_kernel_code_t fields.
ClosedPublic

Authored by vpykhtin on Jun 15 2016, 7:41 AM.

Diff Detail

Event Timeline

vpykhtin updated this revision to Diff 60833.Jun 15 2016, 7:41 AM
vpykhtin retitled this revision from to [AMDGPU] Enable absolute expression initializer for amd_kernel_code_t fields..
vpykhtin updated this object.
SamWot accepted this revision.Jun 15 2016, 7:53 AM
SamWot edited edge metadata.
This revision is now accepted and ready to land.Jun 15 2016, 7:53 AM
artem.tamazov added inline comments.Jun 16 2016, 8:57 AM
lib/Target/AMDGPU/Utils/AMDKernelCodeTUtils.cpp
105

Rename function to express new semantics.

vpykhtin updated this revision to Diff 61103.Jun 17 2016, 9:06 AM
vpykhtin edited edge metadata.

Renamed expectEqualInt to expectAbsExpression.

After running lit tests on linux it turned out that parseAbsExpression eats terminating EndOfStatement token, so I disabled this check for now. Later I'm going to split amd_kernel_code_t directive to a sequence of directives so that field definitions could be interleaved with conditional directives.

artem.tamazov edited edge metadata.Jun 20 2016, 2:15 AM

Renamed expectEqualInt to expectAbsExpression.

Well, new semantics is not just "expect" but "parse" as well.
I would recommend renaming the function some day...

artem.tamazov accepted this revision.Jun 20 2016, 2:16 AM
artem.tamazov edited edge metadata.
This revision was automatically updated to reflect the committed changes.