Page MenuHomePhabricator

Adding Cortex-A73 as an available target.
ClosedPublic

Authored by SjoerdMeijer on Jun 1 2016, 7:09 AM.

Details

Summary

This adds support for Cortex-A73 as an available target.

Clang support is under review in "D20864: Adding support for Cortex-A73"

Diff Detail

Event Timeline

SjoerdMeijer retitled this revision from to Adding Cortex-A73 as an available target..
SjoerdMeijer updated this object.
SjoerdMeijer added a subscriber: llvm-commits.
junbuml added a subscriber: junbuml.Jun 1 2016, 7:23 AM
rengolin edited edge metadata.Jun 1 2016, 7:29 AM

Please, also add it to AArch64TargetParser.def.

Also, be aware that D20762 will probably change the target descriptions a bit.

SjoerdMeijer edited edge metadata.

Also added Cortex-A73 to AArch64TargetParser.def

t.p.northover edited edge metadata.Jun 1 2016, 10:21 AM

I assume AArch64 support is separated off rather than forgotten?

Sorry, ignore that. I misread the diff (I was expecting more lines like in ARM.td).

rengolin added inline comments.Jun 1 2016, 11:54 AM
test/CodeGen/ARM/build-attributes.ll
1415

are you expecting attribute 22?

SjoerdMeijer edited edge metadata.

Thanks Renato, I have added the check for build attribute 22 that somehow got lost.

rengolin accepted this revision.Jun 2 2016, 2:20 AM
rengolin edited edge metadata.

LGTM, Thanks!

This revision is now accepted and ready to land.Jun 2 2016, 2:20 AM

Sorry for asking, but would you mind looking at the Clang part in D20864 as well? Thanks.

This revision was automatically updated to reflect the committed changes.