Page MenuHomePhabricator

Init tsan with .preinit_array section
ClosedPublic

Authored by vitalybuka on May 25 2016, 2:19 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

vitalybuka updated this revision to Diff 58513.May 25 2016, 2:19 PM
vitalybuka retitled this revision from to Init tsan with .preinit_array section.
vitalybuka updated this object.
vitalybuka added reviewers: kcc, eugenis.
vitalybuka added a subscriber: llvm-commits.
kcc accepted this revision.May 25 2016, 2:27 PM
kcc edited edge metadata.

LGTM, assuming all tests pass.
Watch the bots, there could be some build mode (GO?) that can't use .preinit_array but forgets to define SANITIZER_CAN_USE_PREINIT_ARRAY

I don't know why we did not do this in the past.
Dmitry may know, but he is OOO and I don't want this to be blocked.

This revision is now accepted and ready to land.May 25 2016, 2:27 PM
kcc added a comment.May 25 2016, 2:28 PM

Wait a sec. What about a test?

vitalybuka updated this revision to Diff 58558.May 25 2016, 8:35 PM
vitalybuka edited edge metadata.

Added test

kcc added a comment.May 26 2016, 9:40 AM

LGTM, excellent.
Assuming that the test fails w/o your change and passes w/ it.

Mark android as unsupported.

This revision was automatically updated to reflect the committed changes.