This is an archive of the discontinued LLVM Phabricator instance.

[PowerPC] Add a testcase for TCO on string rvo function
ClosedPublic

Authored by timshen on May 16 2016, 4:22 PM.

Diff Detail

Event Timeline

timshen updated this revision to Diff 57416.May 16 2016, 4:22 PM
timshen retitled this revision from to [PowerPC] Add a testcase for TCO on string rvo function.
timshen updated this object.
timshen added reviewers: echristo, kbarton, hfinkel.
timshen added a subscriber: llvm-commits.
iteratee edited edge metadata.May 20 2016, 12:44 PM

Small nit. Other than that looks good.

test/CodeGen/PowerPC/tailcall-string-rvo.ll
2

Can you put this near the function being checked, and add a CHECK-LABEL line?

timshen updated this revision to Diff 58016.May 20 2016, 3:42 PM
timshen edited edge metadata.

Move checks closer to the function.

iteratee accepted this revision.May 20 2016, 3:43 PM
iteratee edited edge metadata.
This revision is now accepted and ready to land.May 20 2016, 3:43 PM
This revision was automatically updated to reflect the committed changes.
timshen marked an inline comment as done.
echristo edited edge metadata.May 23 2016, 12:58 PM

I know you've already committed, but a couple of small requests.

Thanks!

llvm/trunk/test/CodeGen/PowerPC/tailcall-string-rvo.ll
19–23 ↗(On Diff #58017)

Can you move this to the top please? And add a comment of what you want to be testing here?