This is an archive of the discontinued LLVM Phabricator instance.

[PowerPC] Run reg2mem on tests to simplify them.
ClosedPublic

Authored by gberry on May 13 2016, 8:18 AM.

Details

Summary

This change is needed to avoid spurious diffs in these tests when
EarlyCSE is improved to use MemorySSA and can do more load elimination.

Diff Detail

Event Timeline

gberry updated this revision to Diff 57192.May 13 2016, 8:18 AM
gberry retitled this revision from to [PowerPC] Run reg2mem on tests to simplify them..
gberry updated this object.
gberry added a reviewer: hfinkel.
gberry added a subscriber: llvm-commits.
joerg added a subscriber: joerg.May 15 2016, 8:59 AM
joerg added inline comments.
test/CodeGen/PowerPC/vsx-ldst-builtin-le.ll
3

Can we just use FileCheck here and match for 12 lines with lxvd2x and a -NOT for a 13th line?
Similar for stxvd2x. That would remove the grep dependency, which is frowned upon.

gberry updated this revision to Diff 57355.May 16 2016, 9:01 AM

Update to change grep run lines to use FileCheck instead based on review comments.

Ping? Can someone familiar with PowerPC give this a quick look?

mcrosier accepted this revision.Jun 2 2016, 10:33 AM
mcrosier edited edge metadata.

LGTM.

test/CodeGen/PowerPC/builtins-ppc-p8vector.ll
16

You could likely further simplify these tests by passing in and returning vectors, but I don't think that's necessary.

This revision is now accepted and ready to land.Jun 2 2016, 10:33 AM
This revision was automatically updated to reflect the committed changes.