Page MenuHomePhabricator

[Compiler-rt] Mark getpwnam_r_invalid_user as expected failure for MIPS
AbandonedPublic

Authored by mohit.bhakkad on Mar 21 2016, 4:47 AM.

Details

Summary

On MIPS, there might be leak of some memory in libc when we call getpwnam_r, so it fails with a lsan error, otherwise assertions used in this test are positive.

Diff Detail

Repository
rL LLVM

Event Timeline

mohit.bhakkad retitled this revision from to [Compiler-rt] Mark getpwnam_r_invalid_user as expected failure for MIPS.
mohit.bhakkad updated this object.
mohit.bhakkad added reviewers: kcc, eugenis, samsonov.
mohit.bhakkad set the repository for this revision to rL LLVM.

Please investigate this issue in more details. "There might be some leak in getpwnam_r" is not a good enough reason to exclude this test on MIPS (note that it also runs for ASan, TSan, MSan, not just for LSan).

vitalybuka accepted this revision.Mar 21 2016, 10:52 AM
vitalybuka edited edge metadata.
This revision is now accepted and ready to land.Mar 21 2016, 10:52 AM
vitalybuka requested changes to this revision.Mar 21 2016, 12:01 PM
vitalybuka edited edge metadata.

Please followup on samsonov@ comment.

This revision now requires changes to proceed.Mar 21 2016, 12:01 PM
vitalybuka resigned from this revision.Mar 21 2016, 12:04 PM
vitalybuka removed a reviewer: vitalybuka.

@samsonov sure I will investigate libc code and get back to you.
Till now,
I have tried replacing original libc call with a dummy stub of getpwnam_r returning same values, which makes the test pass.
Also with msan, tsan test passes without fail.

mohit.bhakkad abandoned this revision.Apr 14 2016, 3:44 AM

Looks like there was issue with some library on the machine I was working on previously, as I am unable to replicate error on any other mips(el/eb) machine.
Abandoning this change.
Thanks!