Expose the option to disable building with ITT

[hfinkel]

Summary

For the purposes of building the OpenMP runtime library on non-x86 platforms (especially when statically linking because ittnotify_static.c calls dlopen, etc.), ITT sometimes needs to be disabled. We currently have an option for this, but it is forced on. Making this an option allows turning this off without editing the CMake file.

[AndreyChurbanov]

runtime/CMakeLists.txt

202–203

"Right now, always." looks wrong with this change, and should probably be removed from the comment.

[jcownie]

Looks fine.

However I do wonder whether the itt_notify code is useful at all on non-X86 systems,
since it provides the interface to Vtune, and I doubt that Vtune would be available
or happy on non-x86 machines :-).

In which case it might be better to default this off on non-X86 machines anyway.

• Jim

James Cownie <[e-mail]>
SSG/DPD/TCAR (Technical Computing, Analyzers and Runtimes)
Tel: [phone]

[hfinkel]

Update comment as suggested.

[hfinkel]

runtime/CMakeLists.txt

202–203

Good point.

[hfinkel]

• Original Message -----

From: "Jim Cownie via Openmp-commits" <[e-mail]>
To: "james h cownie" <[e-mail]>, [e-mail]
Sent: Thursday, March 17, 2016 10:30:22 AM
Subject: Re: [Openmp-commits] [PATCH] D18244: Expose the option to disable building with ITT

jcownie added a subscriber: jcownie.
jcownie added a comment.

Looks fine.

However I do wonder whether the itt_notify code is useful at all on
non-X86 systems,
since it provides the interface to Vtune, and I doubt that Vtune
would be available
or happy on non-x86 machines :-).

In which case it might be better to default this off on non-X86
machines anyway.

Do we have an easy way of doing this in the CMake file? It looks like I need to do something like:

if (IA32 OR INTEL64 OR MIC)
make the default on
else()
make the default off
endif()

• Jim

James Cownie <[e-mail]>
SSG/DPD/TCAR (Technical Computing, Analyzers and Runtimes)
Tel: [phone]

http://reviews.llvm.org/D18244

---

Openmp-commits mailing list
[e-mail]
http://lists.llvm.org/cgi-bin/mailman/listinfo/openmp-commits

[jlpeyton]

Do we have an easy way of doing this in the CMake file? It looks like I need to do something like:
if (IA32 OR INTEL64 OR MIC)
make the default on
else()
make the default off
endif()

That's one way, the other way (the pattern I adapted when refactoring) is to put something like this in cmake/config-ix.cmake:

# Check if itt notify is available.  Right now it is only verified to work on x86 based architectures
if(IA32 OR INTEL64 OR MIC)
  set(LIBOMP_HAVE_ITT_NOTIFY TRUE)
else()
  set(LIBOMP_HAVE_ITT_NOTIFY FALSE)
endif()

and then in CMakeLists.txt:

set(LIBOMP_USE_ITT_NOTIFY "${LIBOMP_HAVE_ITT_NOTIFY}" CACHE BOOL
  "Should itt notify interface be built?")

[AndreyChurbanov]

This had been covered by the change http://reviews.llvm.org/D20517 (commit rL270884).

[hfinkel]

Subsumed into D20517.

runtime/CMakeLists.txt

if("${libomp_build_type_lowercase}" STREQUAL "release")
   set(RELEASE_BUILD TRUE)
 elseif("${libomp_build_type_lowercase}" STREQUAL "debug")
   set(DEBUG_BUILD TRUE)
 elseif("${libomp_build_type_lowercase}" STREQUAL "relwithdebinfo")
   set(RELWITHDEBINFO_BUILD TRUE)
 elseif("${libomp_build_type_lowercase}" STREQUAL "minsizerel")
   set(MINSIZEREL_BUILD TRUE)
 endif()
 
-# Include itt notify interface? Right now, always.
-set(LIBOMP_USE_ITT_NOTIFY TRUE)
+# Include itt notify interface?
+set(LIBOMP_USE_ITT_NOTIFY TRUE CACHE BOOL
+  "Use the ITT notify interface")
 
 # normal, profile, stubs library.
 set(NORMAL_LIBRARY FALSE)
 set(STUBS_LIBRARY FALSE)
 set(PROFILE_LIBRARY FALSE)
 if("${LIBOMP_LIB_TYPE}" STREQUAL "normal")
   set(NORMAL_LIBRARY TRUE)
 elseif("${LIBOMP_LIB_TYPE}" STREQUAL "profile")