Page MenuHomePhabricator

[Compiler-rt] Fix ioctl codes for MIPS in sanitizer_ioctl_test
ClosedPublic

Authored by mohit.bhakkad on Mar 9 2016, 3:43 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

mohit.bhakkad retitled this revision from to [Compiler-rt] Fix ioctl codes for MIPS in sanitizer_ioctl_test.
mohit.bhakkad updated this object.
mohit.bhakkad added reviewers: eugenis, samsonov, kcc.
mohit.bhakkad set the repository for this revision to rL LLVM.
samsonov added inline comments.Mar 9 2016, 3:48 PM
lib/sanitizer_common/tests/sanitizer_ioctl_test.cc
81

Try to avoid #if where possible. E.g. can you make it

unsigned int desc_value = SANITIZER_MIPS ? 0x4004ae98U : 0x8004ae98U;
bool res = ioctl_decode(write_desc, &desc);

?

changed as suggested.

samsonov accepted this revision.Mar 10 2016, 10:35 AM
samsonov edited edge metadata.

LGTM

This revision is now accepted and ready to land.Mar 10 2016, 10:35 AM
This revision was automatically updated to reflect the committed changes.