This is an archive of the discontinued LLVM Phabricator instance.

Um, no, let's follow the strategy we use for other macros here and always define SANITIZER_MIPS, SANITIZER_MIPS64 and SANITIZER_MIPS32 to either 1, or 0.

samsonov requested changes to this revision.Mar 4 2016, 11:05 AM

samsonov edited edge metadata.

This revision now requires changes to proceed.Mar 4 2016, 11:05 AM

Changing as suggested.

filcab added a subscriber: filcab.Mar 7 2016, 1:23 AM

filcab added inline comments.

lib/sanitizer_common/sanitizer_platform.h
106	Missing `SANITIZER_MIPS32` and `SANITIZER_MIPS64` defined to `0`.

Thanks, added it.

LGTM

This revision is now accepted and ready to land.Mar 8 2016, 12:11 PM

Closed by commit rL263000: [Compiler-rt][MIPS] Defining macros for MIPS archs (authored by mohit.bhakkad). · Explain WhyMar 9 2016, 12:02 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

lib/

sanitizer_common/

sanitizer_platform.h

9 lines

Diff 49809

lib/sanitizer_common/sanitizer_platform.h

	Show First 20 Lines • Show All 87 Lines • ▼ Show 20 Lines
	#endif			#endif

	#if defined(__x86_64__) && !defined(_LP64)			#if defined(__x86_64__) && !defined(_LP64)
	# define SANITIZER_X32 1			# define SANITIZER_X32 1
	#else			#else
	# define SANITIZER_X32 0			# define SANITIZER_X32 0
	#endif			#endif

				#if defined(__mips__)
				# define SANITIZER_MIPS 1
				eugenisUnsubmitted Not Done Reply Inline Actions #else #define SANITIZER_MIPS 0 the some for the other two eugenis: #else #define SANITIZER_MIPS 0 the some for the other two
				# if defined(__mips64)
				# define SANITIZER_MIPS64 1
				# else
				# define SANITIZER_MIPS32 1
				# endif
				#endif

	// By default we allow to use SizeClassAllocator64 on 64-bit platform.			// By default we allow to use SizeClassAllocator64 on 64-bit platform.
	// But in some cases (e.g. AArch64's 39-bit address space) SizeClassAllocator64			// But in some cases (e.g. AArch64's 39-bit address space) SizeClassAllocator64
				filcabUnsubmitted Not Done Reply Inline Actions Missing `SANITIZER_MIPS32` and `SANITIZER_MIPS64` defined to `0`. filcab: Missing `SANITIZER_MIPS32` and `SANITIZER_MIPS64` defined to `0`.
	// does not work well and we need to fallback to SizeClassAllocator32.			// does not work well and we need to fallback to SizeClassAllocator32.
	// For such platforms build this code with -DSANITIZER_CAN_USE_ALLOCATOR64=0 or			// For such platforms build this code with -DSANITIZER_CAN_USE_ALLOCATOR64=0 or
	// change the definition of SANITIZER_CAN_USE_ALLOCATOR64 here.			// change the definition of SANITIZER_CAN_USE_ALLOCATOR64 here.
	#ifndef SANITIZER_CAN_USE_ALLOCATOR64			#ifndef SANITIZER_CAN_USE_ALLOCATOR64
	# if defined(__mips64) \|\| defined(__aarch64__)			# if defined(__mips64) \|\| defined(__aarch64__)
	# define SANITIZER_CAN_USE_ALLOCATOR64 0			# define SANITIZER_CAN_USE_ALLOCATOR64 0
	# else			# else
	# define SANITIZER_CAN_USE_ALLOCATOR64 (SANITIZER_WORDSIZE == 64)			# define SANITIZER_CAN_USE_ALLOCATOR64 (SANITIZER_WORDSIZE == 64)
	▲ Show 20 Lines • Show All 66 Lines • Show Last 20 Lines

This is an archive of the discontinued LLVM Phabricator instance.

[Compiler-rt][MIPS] Defining macros for MIPS archsClosedPublic

Details

Diff Detail

Event Timeline

Revision Contents

Diff 49809

lib/sanitizer_common/sanitizer_platform.h

[Compiler-rt][MIPS] Defining macros for MIPS archs
ClosedPublic