This is an archive of the discontinued LLVM Phabricator instance.

[Compiler-rt] Use __gnu_linux instead of linux__ to detect Linux OS
AbandonedPublic

Authored by mohit.bhakkad on Mar 4 2016, 2:26 AM.

Reviewers

kcc

Summary

linux is defined for linux kernel.
gnu_linux is defined for linux os.

linux will be present in android also making SANITIZER_LINUX true for android.
So, I suggest we use gnu_linux instead of linux.

mohit.bhakkad retitled this revision from to [Compiler-rt] Use __gnu_linux__ instead of __linux__ to detect Linux OS.

mohit.bhakkad updated this object.

mohit.bhakkad added a reviewer: kcc.

mohit.bhakkad set the repository for this revision to rL LLVM.

linux will be present in android also making SANITIZER_LINUX true for android.

Isn't this intended? In (few) places where libsanitizer needs to distinguish between Linux and Android it explicitly checks for

#if (SANITIZER_LINUX && !SANITIZER_ANDROID)

Thanks, I will abandon this patch.

Path

Size

lib/

sanitizer_common/

2 lines

	Show All 12 Lines
	#ifndef SANITIZER_PLATFORM_H			#ifndef SANITIZER_PLATFORM_H
	#define SANITIZER_PLATFORM_H			#define SANITIZER_PLATFORM_H

	#if !defined(__linux__) && !defined(__FreeBSD__) && \			#if !defined(__linux__) && !defined(__FreeBSD__) && \
	!defined(__APPLE__) && !defined(_WIN32)			!defined(__APPLE__) && !defined(_WIN32)
	# error "This operating system is not supported"			# error "This operating system is not supported"
	#endif			#endif

	#if defined(__linux__)			#if defined(__gnu_linux__)
	# define SANITIZER_LINUX 1			# define SANITIZER_LINUX 1
	#else			#else
	# define SANITIZER_LINUX 0			# define SANITIZER_LINUX 0
	#endif			#endif

	#if defined(__FreeBSD__)			#if defined(__FreeBSD__)
	# define SANITIZER_FREEBSD 1			# define SANITIZER_FREEBSD 1
	#else			#else
	▲ Show 20 Lines • Show All 142 Lines • Show Last 20 Lines