Page MenuHomePhabricator

AMDGPU: Fix ordering of CPU and FS parameters in TargetMachine constructors
ClosedPublic

Authored by tstellarAMD on Feb 3 2016, 12:21 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

tstellarAMD retitled this revision from to AMDGPU: Fix ordering of CPU and FS parameters in TargetMachine constructors.
tstellarAMD updated this object.
tstellarAMD added a reviewer: arsenm.
tstellarAMD added a subscriber: llvm-commits.
arsenm accepted this revision.Feb 3 2016, 12:27 PM
arsenm edited edge metadata.

LGTM. How was this working at all before?

This revision is now accepted and ready to land.Feb 3 2016, 12:27 PM
tstellarAMD edited edge metadata.

Fix header files too.

LGTM. How was this working at all before?

We were passing the correct values, it's just that the parameter names were wrong.

This revision was automatically updated to reflect the committed changes.