Page MenuHomePhabricator

[CMake] Introduce OPENMP_LLVM_TOOLS_DIR
ClosedPublic

Authored by Hahnfeld on Jan 29 2016, 12:56 AM.

Details

Summary

This will be used in a later patch to find additional LLVM tools for tests and enables reusability for libomptarget that is currently under review.

(or can LIBOMP_LLVM_LIT_EXECUTABLE be completely replaced by LIBOMP_LLVM_TOOLS_DIR?)

Diff Detail

Event Timeline

Hahnfeld updated this revision to Diff 46361.Jan 29 2016, 12:56 AM
Hahnfeld retitled this revision from to [CMake] Introduce LIBOMP_LLVM_TOOLS_DIR.
Hahnfeld updated this object.
Hahnfeld added reviewers: jlpeyton, AndreyChurbanov.
Hahnfeld added subscribers: openmp-commits, tcramer.
jlpeyton accepted this revision.Feb 1 2016, 10:01 AM
jlpeyton edited edge metadata.

LGTM.

This revision is now accepted and ready to land.Feb 1 2016, 10:01 AM

(or can LIBOMP_LLVM_LIT_EXECUTABLE be completely replaced by LIBOMP_LLVM_TOOLS_DIR?)

For now, lets just leave it.

Hahnfeld updated this revision to Diff 46617.Feb 1 2016, 11:25 PM
Hahnfeld retitled this revision from [CMake] Introduce LIBOMP_LLVM_TOOLS_DIR to [CMake] Introduce OPENMP_LLVM_TOOLS_DIR.
Hahnfeld updated this object.
Hahnfeld edited edge metadata.
Hahnfeld added a subscriber: sfantao.

Rename LIBOMP_LLVM_TOOLS_DIR to OPENMP_LLVM_TOOLS_DIR to later reuse it for libomptarget

Rename LIBOMP_LLVM_TOOLS_DIR to OPENMP_LLVM_TOOLS_DIR to later reuse it for libomptarget

Where is libomptarget going to be placed?

Rename LIBOMP_LLVM_TOOLS_DIR to OPENMP_LLVM_TOOLS_DIR to later reuse it for libomptarget

Where is libomptarget going to be placed?

See D14031

Ok. I understand now. You can go ahead and apply this patch.

This revision was automatically updated to reflect the committed changes.