Page MenuHomePhabricator

Adding doxygen comments to the LLVM intrinsics (part 3, __wmmintrin_aes.h)
ClosedPublic

Authored by kromanova on Jan 25 2016, 4:16 PM.

Details

Summary

Hello,

Here is the patch with the doxygen comments for the intrinsincs in the header file __wmmintrin_aes.h.
The doxygen comments are automatically generated based on SCE internal intrinsics document using DCG tool that I wrote.

I will submit more doxygen comments for the other intrinsic header files as soon as this patch is approved.

Here is the link to the general discussion about adding comments to x86 intrinsics headers.
http://permalink.gmane.org/gmane.comp.compilers.clang.devel/42032

Here are the links to the similar code reviews for the doxygen comments in ammintrin.h and _wmmintrin_pclmul.h
http://reviews.llvm.org/D8762 (closed)
http://reviews.llvm.org/D15999 (still needs review)

Katya.

Diff Detail

Repository
rL LLVM

Event Timeline

kromanova updated this revision to Diff 45924.Jan 25 2016, 4:16 PM
kromanova retitled this revision from to Adding doxygen comments to the LLVM intrinsics (part 3, __wmmintrin_aes.h).
kromanova updated this object.
kromanova set the repository for this revision to rL LLVM.
kromanova added subscribers: silvas, echristo, cfe-commits.

Hi Eric,
Could you please accept this revision also?
I have already added missing article "the" in "This intrinsic corresponds to <instruction name> instruction" (as you requested in the other doxygen comments review).

Thank you!
Katya.

echristo accepted this revision.Jan 29 2016, 1:32 PM
echristo added a reviewer: echristo.

Yep. :)

This revision is now accepted and ready to land.Jan 29 2016, 1:32 PM
This revision was automatically updated to reflect the committed changes.