This is an archive of the discontinued LLVM Phabricator instance.

Differential D16006

[libcxxabi] Teach cxa_demangle about Hexagon's long double size
ClosedPublic

Authored by bcraig on Jan 8 2016, 12:07 PM.

Details

Reviewers
mclow.lists
dsanders
rengolin
logan
EricWF
howard.hinnant
Summary

cxa_demangle's default size for a long double is 10 bytes. Hexagon only has an 8 byte long double though.

Diff Detail

Event Timeline

bcraig updated this revision to Diff 44356.Jan 8 2016, 12:07 PM
bcraig retitled this revision from to [libcxxabi] Teach cxa_demangle about Hexagon's long double size.
bcraig updated this object.
bcraig added reviewers: howard.hinnant, logan, dsanders, rengolin.
bcraig added a subscriber: cfe-commits.
bcraig added a reviewer: mclow.lists.Jan 18 2016, 8:04 AM

ping

EricWF accepted this revision.Jan 20 2016, 1:27 AM
EricWF added a reviewer: EricWF.
EricWF added a subscriber: EricWF.

LGTM.

This revision is now accepted and ready to land.Jan 20 2016, 1:27 AM
bcraig closed this revision.Jan 20 2016, 6:15 AM

Revision Contents

PathSize
src/
2 lines

Diff 44356

src/cxa_demangle.cpp

Context not available.
{ {
#if defined(__mips__) && defined(__mips_n64) || defined(__aarch64__) #if defined(__mips__) && defined(__mips_n64) || defined(__aarch64__)
static const size_t mangled_size = 32; static const size_t mangled_size = 32;
#elif defined(__arm__) || defined(__mips__) #elif defined(__arm__) || defined(__mips__) || defined(__hexagon__)
static const size_t mangled_size = 16; static const size_t mangled_size = 16;
#else #else
static const size_t mangled_size = 20; // May need to be adjusted to 16 or 24 on other platforms static const size_t mangled_size = 20; // May need to be adjusted to 16 or 24 on other platforms
Context not available.