This is an archive of the discontinued LLVM Phabricator instance.

Differential D159521

[BOLT][runtime] Test for outline-atomics support
ClosedPublic

Authored by yota9 on Sep 15 2023, 3:54 AM.

Details

Reviewers
maksfb
rafauler
Amir
Commits
rG80c01dd626e0: [BOLT][runtime] Test for outline-atomics support
Summary

I'm using clang-10 to build bolt which doesn't have moutline-atomics
option and though it doesn't do it. So test compiler for supporting it
before appending to the list of cxxflags.

Diff Detail

Event Timeline

yota9 created this revision.Sep 15 2023, 3:54 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 15 2023, 3:54 AM
Herald added subscribers: treapster, ayermolo. · View Herald Transcript
yota9 requested review of this revision.Sep 15 2023, 3:54 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 15 2023, 3:54 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B257267: Diff 556841.Sep 15 2023, 4:16 AM
yota9 added a comment.Sep 18 2023, 10:33 AM

Gentle ping @Amir @maksfb

Amir accepted this revision.Sep 18 2023, 10:35 AM
This revision is now accepted and ready to land.Sep 18 2023, 10:35 AM
Closed by commit rG80c01dd626e0: [BOLT][runtime] Test for outline-atomics support (authored by yota9). · Explain WhySep 19 2023, 12:29 PM
This revision was automatically updated to reflect the committed changes.
yota9 added a commit: rG80c01dd626e0: [BOLT][runtime] Test for outline-atomics support.

Revision Contents

PathSize
bolt/
runtime/
6 lines

Diff 557070

bolt/runtime/CMakeLists.txt

cmake_minimum_required(VERSION 3.20.0) cmake_minimum_required(VERSION 3.20.0)
include(CheckCXXCompilerFlag)
include(CheckIncludeFiles) include(CheckIncludeFiles)
include(GNUInstallDirs) include(GNUInstallDirs)
set(CMAKE_CXX_EXTENSIONS OFF) set(CMAKE_CXX_EXTENSIONS OFF)
set(CMAKE_CXX_STANDARD 17) set(CMAKE_CXX_STANDARD 17)
project(libbolt_rt_project) project(libbolt_rt_project)
Show All 18 Linesset(BOLT_RT_FLAGS
-fno-rtti -fno-rtti
-fno-stack-protector -fno-stack-protector
-fPIC -fPIC
-mgeneral-regs-only) -mgeneral-regs-only)
if (CMAKE_SYSTEM_PROCESSOR MATCHES "x86_64") if (CMAKE_SYSTEM_PROCESSOR MATCHES "x86_64")
set(BOLT_RT_FLAGS ${BOLT_RT_FLAGS} "-mno-sse") set(BOLT_RT_FLAGS ${BOLT_RT_FLAGS} "-mno-sse")
endif() endif()
if (CMAKE_SYSTEM_PROCESSOR MATCHES "aarch64") if (CMAKE_SYSTEM_PROCESSOR MATCHES "aarch64")
check_cxx_compiler_flag("-mno-outline-atomics" CXX_SUPPORTS_OUTLINE_ATOMICS)
if (CXX_SUPPORTS_OUTLINE_ATOMICS)
set(BOLT_RT_FLAGS ${BOLT_RT_FLAGS} "-mno-outline-atomics") set(BOLT_RT_FLAGS ${BOLT_RT_FLAGS} "-mno-outline-atomics")
endif() endif()
endif()
# Don't let the compiler think it can create calls to standard libs # Don't let the compiler think it can create calls to standard libs
target_compile_options(bolt_rt_instr PRIVATE ${BOLT_RT_FLAGS}) target_compile_options(bolt_rt_instr PRIVATE ${BOLT_RT_FLAGS})
target_include_directories(bolt_rt_instr PRIVATE ${CMAKE_CURRENT_BINARY_DIR}) target_include_directories(bolt_rt_instr PRIVATE ${CMAKE_CURRENT_BINARY_DIR})
target_compile_options(bolt_rt_hugify PRIVATE ${BOLT_RT_FLAGS}) target_compile_options(bolt_rt_hugify PRIVATE ${BOLT_RT_FLAGS})
target_include_directories(bolt_rt_hugify PRIVATE ${CMAKE_CURRENT_BINARY_DIR}) target_include_directories(bolt_rt_hugify PRIVATE ${CMAKE_CURRENT_BINARY_DIR})
install(TARGETS bolt_rt_instr DESTINATION "lib${LLVM_LIBDIR_SUFFIX}") install(TARGETS bolt_rt_instr DESTINATION "lib${LLVM_LIBDIR_SUFFIX}")
Show All 14 Lines