This is an archive of the discontinued LLVM Phabricator instance.

[libc][math] Extract non-MPFR math tests into libc-math-smoke-tests.
ClosedPublic

Authored by lntue on Sep 6 2023, 7:15 PM.

Details

Summary

Extract non-MPFR math tests into libc-math-smoke-tests.

Diff Detail

Event Timeline

lntue created this revision.Sep 6 2023, 7:15 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptSep 6 2023, 7:15 PM
lntue requested review of this revision.Sep 6 2023, 7:15 PM

Thanks for this, it exposed some missing implementations in the GPU math. I opened https://github.com/llvm/llvm-project/pull/65616 to address those. With this applied, the GPU build passes all the new smoke tests except for the check for round(-0.0) == -0.0 for AMDGPU.

sivachandra accepted this revision.Sep 12 2023, 12:45 PM
This revision is now accepted and ready to land.Sep 12 2023, 12:45 PM

This passes for the GPU once a fix made by @arsenm was applied. If that fix gets in quickly we could wait to land, alternatively just disable the test rounding for AMDGPU.

lntue updated this revision to Diff 556786.Sep 14 2023, 8:22 AM

Update cmake targets dependency and documentations.

jhuber6 accepted this revision.Sep 19 2023, 6:24 AM

The GPU build passes all the new tests now, thanks.