This is an archive of the discontinued LLVM Phabricator instance.

Differential D159316

[OpenMP] Change default gtid mode to 2 for darwin
AbandonedPublic

Authored by tianshilei1992 on Aug 31 2023, 3:29 PM.

Details

Reviewers
tlwilmar
jlpeyton
jdoerfert
Summary

On Darwin the default gtid mode is 0, which means it will be determined based on number of threads. This patch changes the default mode to 2 for Darwin.

Diff Detail

Event Timeline

tianshilei1992 created this revision.Aug 31 2023, 3:29 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 31 2023, 3:29 PM
Herald added subscribers: guansong, yaxunl. · View Herald Transcript
tianshilei1992 requested review of this revision.Aug 31 2023, 3:29 PM
Herald added a reviewer: jdoerfert. · View Herald TranscriptAug 31 2023, 3:29 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: openmp-commits, jplehr, sstefan1. · View Herald Transcript
Harbormaster completed remote builds in B256121: Diff 555182.Aug 31 2023, 3:32 PM
tianshilei1992 edited the summary of this revision. (Show Details)Aug 31 2023, 6:01 PM
jdoerfert added a comment.Aug 31 2023, 6:10 PM

and this is better? You have any data?

tianshilei1992 abandoned this revision.Aug 31 2023, 6:11 PM

Revision Contents

PathSize
openmp/
runtime/
src/
2 lines

Diff 555182

openmp/runtime/src/kmp_global.cpp

Show First 20 Lines • Show All 169 Lines • ▼ Show 20 Lines
int __kmp_ncores = 0; int __kmp_ncores = 0;
#endif #endif
int __kmp_chunk = 0; int __kmp_chunk = 0;
int __kmp_force_monotonic = 0; int __kmp_force_monotonic = 0;
int __kmp_abort_delay = 0; int __kmp_abort_delay = 0;
#if KMP_OS_LINUX && defined(KMP_TDATA_GTID) #if KMP_OS_LINUX && defined(KMP_TDATA_GTID)
int __kmp_gtid_mode = 3; /* use __declspec(thread) TLS to store gtid */ int __kmp_gtid_mode = 3; /* use __declspec(thread) TLS to store gtid */
int __kmp_adjust_gtid_mode = FALSE; int __kmp_adjust_gtid_mode = FALSE;
#elif KMP_OS_WINDOWS #elif KMP_OS_WINDOWS || KMP_OS_DARWIN
int __kmp_gtid_mode = 2; /* use TLS functions to store gtid */ int __kmp_gtid_mode = 2; /* use TLS functions to store gtid */
int __kmp_adjust_gtid_mode = FALSE; int __kmp_adjust_gtid_mode = FALSE;
#else #else
int __kmp_gtid_mode = 0; /* select method to get gtid based on #threads */ int __kmp_gtid_mode = 0; /* select method to get gtid based on #threads */
int __kmp_adjust_gtid_mode = TRUE; int __kmp_adjust_gtid_mode = TRUE;
#endif /* KMP_OS_LINUX && defined(KMP_TDATA_GTID) */ #endif /* KMP_OS_LINUX && defined(KMP_TDATA_GTID) */
#ifdef KMP_TDATA_GTID #ifdef KMP_TDATA_GTID
KMP_THREAD_LOCAL int __kmp_gtid = KMP_GTID_DNE; KMP_THREAD_LOCAL int __kmp_gtid = KMP_GTID_DNE;
▲ Show 20 Lines • Show All 389 Lines • Show Last 20 Lines