This is an archive of the discontinued LLVM Phabricator instance.

Differential D159307

[Sema] add test cases for D152495 NFC
ClosedPublic

Authored by nickdesaulniers on Aug 31 2023, 12:56 PM.

Details

Reviewers
aaron.ballman
hazohelet
nathanchance
cor3ntin
MaskRay
Commits
rGcfa578cde031: [Sema] add test cases for D152495 NFC
Summary

Ensure these don't regress the next time we reland D152495.

Link: https://github.com/ClangBuiltLinux/linux/issues/1926

Diff Detail

Event Timeline

nickdesaulniers created this revision.Aug 31 2023, 12:56 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 31 2023, 12:56 PM
nickdesaulniers requested review of this revision.Aug 31 2023, 12:56 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 31 2023, 12:56 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
nickdesaulniers added reviewers: aaron.ballman, hazohelet, nathanchance, cor3ntin.Aug 31 2023, 12:57 PM
cor3ntin accepted this revision.Aug 31 2023, 1:00 PM

LGTM (this could be a NFC change)

This revision is now accepted and ready to land.Aug 31 2023, 1:00 PM
nickdesaulniers retitled this revision from [Sema] add test cases for D152495 to [Sema] add test cases for D152495 NFC.Aug 31 2023, 1:43 PM
nickdesaulniers added a reviewer: MaskRay.
MaskRay accepted this revision.Aug 31 2023, 1:46 PM
Harbormaster completed remote builds in B256096: Diff 555144.Aug 31 2023, 1:52 PM
Closed by commit rGcfa578cde031: [Sema] add test cases for D152495 NFC (authored by nickdesaulniers). · Explain WhyAug 31 2023, 2:18 PM
This revision was automatically updated to reflect the committed changes.
nickdesaulniers added a commit: rGcfa578cde031: [Sema] add test cases for D152495 NFC.

Revision Contents

PathSize
clang/
test/
SemaCXX/
3 lines

Diff 555162

clang/test/SemaCXX/warn-unused-variables.cpp

Show All 40 Linesvoid test_dependent_init(T *p) {
X0<int> i(p); X0<int> i(p);
(void)i; (void)i;
} }
void unused_local_static() { void unused_local_static() {
static int x = 0; static int x = 0;
static int y = 0; // expected-warning{{unused variable 'y'}} static int y = 0; // expected-warning{{unused variable 'y'}}
#pragma unused(x) #pragma unused(x)
static __attribute__((used)) int z;
static __attribute__((unused)) int w;
[[maybe_unused]] static int v;
} }
// PR10168 // PR10168
namespace PR10168 { namespace PR10168 {
// We expect a warning in the definition only for non-dependent variables, and // We expect a warning in the definition only for non-dependent variables, and
// a warning in the instantiation only for dependent variables. // a warning in the instantiation only for dependent variables.
template<typename T> template<typename T>
struct S { struct S {
▲ Show 20 Lines • Show All 240 Lines • Show Last 20 Lines