This is an archive of the discontinued LLVM Phabricator instance.

[AST] Support ConceptReference in DynTypedNode, add dump().
ClosedPublic

Authored by sammccall on Aug 31 2023, 11:25 AM.

Details

Summary

The dump() is not actually included recursively in any other nodes' dump,
as this is too verbose (similar to NNS) but useful in its own right.

It's unfortunate to not have the actual tests yet, but the DynTypedNode
tests are matcher-based and adding matchers is a larger task than
DynTypedNode support (but can't be done first).

(I've got a clangd change stacked on this that uses DynTypedNode and
dump(), and both work. I'll send a change for matchers next).

Diff Detail

Event Timeline

sammccall created this revision.Aug 31 2023, 11:25 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 31 2023, 11:25 AM
Herald added a subscriber: kadircet. · View Herald Transcript
sammccall requested review of this revision.Aug 31 2023, 11:25 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 31 2023, 11:25 AM
massberg accepted this revision.Sep 4 2023, 12:54 AM

Thanks!

This revision is now accepted and ready to land.Sep 4 2023, 12:54 AM
This revision was landed with ongoing or failed builds.Sep 4 2023, 6:26 AM
This revision was automatically updated to reflect the committed changes.